Add comment to extractStringsFromUserInput

timokoessler · timokoessler · commit 4fefb0acc441 · 2025-05-02T12:00:48.000+02:00
diff --git a/library/helpers/extractStringsFromUserInput.ts b/library/helpers/extractStringsFromUserInput.ts
@@ -35,6 +35,8 @@ export function extractStringsFromUserInput(obj: unknown): Set<UserString> {
     if (obj.includes("%") && obj.length >= 3) {
       const r = safeDecodeURIComponent(obj);
       if (r && r !== obj) {
+        // Only add if the decoded value is different from the original, to avoid duplicates in results
+        // This improves the performance of all injection tests
         results.add(r);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ export function extractStringsFromUserInput(obj: unknown): Set<UserString> {`
`35`	`35`	`if (obj.includes("%") && obj.length >= 3) {`
`36`	`36`	`const r = safeDecodeURIComponent(obj);`
`37`	`37`	`if (r && r !== obj) {`
	`38`	`+ // Only add if the decoded value is different from the original, to avoid duplicates in results`
	`39`	`+ // This improves the performance of all injection tests`
`38`	`40`	`results.add(r);`
`39`	`41`	`}`
`40`	`42`	`}`