Set symbol to true and add comment

Author: hansott

library/sources/HTTPServer.stats.test.ts

@@ -162,12 +162,11 @@ t.test("it only counts once if multiple listeners", async () => {
   });
 
   server.on("request", (req, res) => {
-    if (res.headersSent) {
-      return;
-    }
+    // This is a second listener
+  });
 
-    res.setHeader("Content-Type", "text/plain");
-    res.end("OK");
+  server.on("request", (req, res) => {
+    // This is a third listener
   });
 
   await new Promise<void>((resolve) => {
@@ -178,13 +177,15 @@ t.test("it only counts once if multiple listeners", async () => {
           method: "GET",
           headers: {
             "user-agent": "GPTBot",
+            "x-forwarded-for": "1.2.3.4",
           },
           timeoutInMS: 500,
         }),
         fetch({
           url: new URL("http://localhost:3329/test"),
           method: "GET",
           headers: {
+            "user-agent": "GPTBot",
             "x-forwarded-for": "1.2.3.4",
           },
           timeoutInMS: 500,
@@ -196,12 +197,12 @@ t.test("it only counts once if multiple listeners", async () => {
         t.same(userAgents, {
           breakdown: {
             // eslint-disable-next-line camelcase
-            ai_data_scrapers: { total: 1, blocked: 0 },
+            ai_data_scrapers: { total: 2, blocked: 0 },
           },
         });
         t.same(ipAddresses, {
           breakdown: {
-            "known_threat_actors/public_scanners": { total: 1, blocked: 0 },
+            "known_threat_actors/public_scanners": { total: 2, blocked: 0 },
           },
         });
         server.close();

library/sources/http-server/checkIfRequestIsBlocked.ts

@@ -8,9 +8,10 @@ import { ipAllowedToAccessRoute } from "./ipAllowedToAccessRoute";
 const checkedBlocks = Symbol("__zen_checked_blocks__");
 
 /**
- * Inspects the IP address of the request:
+ * Inspects the IP address and user agent of the request:
  * - Whether the IP address is blocked by an IP blocklist (e.g. Geo restrictions)
  * - Whether the IP address is allowed to access the current route (e.g. Admin panel)
+ * - Whether the user agent is blocked by a user agent blocklist
  */
 export function checkIfRequestIsBlocked(
   res: ServerResponse & { [checkedBlocks]?: boolean },
@@ -34,7 +35,7 @@ export function checkIfRequestIsBlocked(
 
   // We don't need to check again if the request has already been checked
   // Also ensures that the statistics are only counted once
-  // res[checkedBlocklist] = true;
+  res[checkedBlocks] = true;
 
   if (!ipAllowedToAccessRoute(context, agent)) {
     res.statusCode = 403;