Skip to content

Commit 9043f7f

Browse files
committed
Add test cases for user where name is not defined
1 parent b1a0424 commit 9043f7f

File tree

2 files changed

+42
-0
lines changed

2 files changed

+42
-0
lines changed

aikido_zen/context/users_test.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,26 @@ def test_set_valid_user():
128128
assert user_1["firstSeenAt"] == user_1["lastSeenAt"]
129129

130130

131+
def test_set_valid_user_without_name():
132+
context1 = set_context_and_lifecycle()
133+
assert context1.user is None
134+
135+
user = {"id": 456}
136+
set_user(user)
137+
138+
assert context1.user == {
139+
"id": "456",
140+
"lastIpAddress": "198.51.100.23",
141+
}
142+
143+
assert len(get_cache().users.as_array()) == 1
144+
user_1 = get_cache().users.as_array()[0]
145+
assert user_1["id"] == "456"
146+
assert user_1["lastIpAddress"] == "198.51.100.23"
147+
assert user_1["name"] is None
148+
assert user_1["firstSeenAt"] == user_1["lastSeenAt"]
149+
150+
131151
def test_re_set_valid_user():
132152
context1 = set_context_and_lifecycle()
133153
assert context1.user is None

aikido_zen/storage/users_test.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,28 @@ def test_as_array_with_multiple_users(users):
178178
assert user_array[1]["id"] == user_id_2
179179

180180

181+
def test_as_array_with_multiple_users_but_one_without_name(users):
182+
user_id_1 = "1"
183+
user_name_1 = "Test User 1"
184+
user_ip_1 = "127.0.0.1"
185+
current_time_1 = datetime.now()
186+
187+
user_id_2 = "2"
188+
user_name_2 = None
189+
user_ip_2 = "192.168.1.1"
190+
current_time_2 = datetime.now()
191+
192+
users.add_user(user_id_1, user_name_1, user_ip_1, current_time_1)
193+
users.add_user(user_id_2, user_name_2, user_ip_2, current_time_2)
194+
195+
user_array = users.as_array()
196+
197+
assert len(user_array) == 2
198+
assert user_array[0]["id"] == user_id_1
199+
assert user_array[1]["id"] == user_id_2
200+
assert user_array[1]["name"] is None
201+
202+
181203
def test_clear_with_multiple_users(users):
182204
user_id_1 = "1"
183205
user_name_1 = "Test User 1"

0 commit comments

Comments
 (0)