try_parse_url_path -> fix multiple slashes issue

Author: bitterpanda63

aikido_zen/helpers/build_route_from_url_test.py

@@ -144,3 +144,22 @@ def test_replaces_ulid_strings():
 
     # 25 characters
     assert build_route_from_url("/posts/01arz3ndektsv4rrffq69g5fa") != "/posts/:ulid"
+
+
+def test_multiple_slashes():
+    assert build_route_from_url("//test_ratelimiting_1//") == "/test_ratelimiting_1"
+
+    assert (
+        build_route_from_url("////posts/66ec29159d00113616fc7184//")
+        == "/posts/:objectId"
+    )
+
+    assert (
+        build_route_from_url("/posts///66ec29159d00113616fc71845")
+        == "/posts/66ec29159d00113616fc71845"
+    )
+
+    assert (
+        build_route_from_url("//posts//66ec29159d00113616fc718//")
+        == "/posts/66ec29159d00113616fc718"
+    )

aikido_zen/helpers/try_parse_url_path.py

@@ -5,6 +5,7 @@
 """
 
 from urllib.parse import urlparse
+import regex as re
 
 
 def try_parse_url(url):
@@ -26,4 +27,9 @@ def try_parse_url_path(url):
         return None
     if parsed.path == "":
         return "/"
-    return parsed.path
+
+    # Multiple slashes are ignored in python, so we want to also remove them here
+    # This allows the route building & endpoint matching to work properly.
+    normalized_path = re.sub(r"/+", "/", parsed.path)
+
+    return normalized_path

aikido_zen/helpers/try_parse_url_path_test.py

@@ -22,6 +22,13 @@ def test_try_parse_url_path_for_absolute_url():
     assert try_parse_url_path("http://localhost/posts/3") == "/posts/3"
 
 
+def test_try_parse_url_path_for_absolute_url_with_multiple_slashes():
+    assert try_parse_url_path("http://localhost/posts//////3////") == "/posts/3/"
+    assert try_parse_url_path("http://localhost/posts//3//") == "/posts/3/"
+    assert try_parse_url_path("http://localhost////") == "/"
+    assert try_parse_url_path("http://localhost//") == "/"
+
+
 def test_try_parse_url_path_for_absolute_url_with_query():
     assert try_parse_url_path("http://localhost/posts/3?abc=def") == "/posts/3"