Use Gem::Version to compare RUBY_VERSION

Author: marksmith

.simplecov

@@ -3,7 +3,7 @@
 # Due to dependency resolution, on Ruby 2.x we're stuck with a _very_ old
 # SimpleCov version, and it doesn't really give us any benefit to run coverage
 # in separate ruby versions since we don't branch on ruby version in the code.
-return if RUBY_VERSION < "3.0"
+return if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("3.0")
 return if ENV["DISABLE_COVERAGE"] == "true"
 
 # Output coverage as LCOV to support CodeCov

bin/console

@@ -3,7 +3,7 @@
 
 require "bundler/setup"
 require "aikido/zen"
-require "debug" if RUBY_VERSION >= "3.0"
+require "debug" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.0")
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

lib/aikido/zen/sinks.rb

@@ -21,7 +21,7 @@
 
 # http.rb aims to support and is tested against Ruby 3.0+:
 # https://github.com/httprb/http?tab=readme-ov-file#supported-ruby-versions
-require_relative "sinks/http" if RUBY_VERSION >= "3.0"
+require_relative "sinks/http" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.0")
 
 require_relative "sinks/httpx"
 require_relative "sinks/httpclient"

test/aikido/zen/scanners/sql_injection_scanner_test.rb

@@ -276,7 +276,7 @@ def refute_attack(query, input = query, *args)
   end
 
   test "it flags regular expression matching timeouts as attacks" do
-    skip if RUBY_VERSION < "3.2"
+    skip_if_ruby_lower_than("3.2")
 
     begin
       timeout = Regexp.timeout

test/aikido/zen/sinks/async_http_test.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # Async::HTTP only supports ruby 3.1+
-return if RUBY_VERSION < "3.1"
+return if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("3.1")
 
 require "test_helper"
 require "async/http/middleware/location_redirector"

test/aikido/zen/sinks/http_test.rb

@@ -2,7 +2,7 @@
 
 # http.rb aims to support and is tested against Ruby 3.0+:
 # https://github.com/httprb/http?tab=readme-ov-file#supported-ruby-versions
-return if RUBY_VERSION < "3.0"
+return if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("3.0")
 
 require "test_helper"
 

test/test_helper.rb

@@ -3,7 +3,7 @@
 require "bundler"
 Bundler.setup
 
-require "simplecov-lcov" if RUBY_VERSION >= "3"
+require "simplecov-lcov" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.0")
 require "simplecov"
 
 $LOAD_PATH.unshift File.expand_path("../lib", __dir__)
@@ -16,7 +16,7 @@
 require "action_dispatch"
 require "action_dispatch/routing/inspector"
 require "pathname"
-require "debug" if RUBY_VERSION >= "3"
+require "debug" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.0")
 require "support/capture_stream"
 
 class FakeDetachedAgent
@@ -167,7 +167,7 @@ def assert_hash_subset_of(container, subset)
   end
 
   def skip_if_ruby_lower_than(expected_ruby_version)
-    if expected_ruby_version > RUBY_VERSION
+    if Gem::Version.new(expected_ruby_version) > Gem::Version.new(RUBY_VERSION)
       skip "Skipping test #{__method__} because unexpected ruby version (#{RUBY_VERSION} < #{expected_ruby_version})"
     end
   end