Bug when one user edits environment and other deletes

[Divyanshu1998]

What happened?

I was logged in two separate tabs. In one tab, I am logged in as SUPERADMIN and in another tab as a user(call user1). user1 is given permission to add/edit/delete environments. user1 has opened "edit environment" tab and at the same time, SUPERADMIN deletes the environment. user1 after making some changes presses the "save" button. And the deleted environment with changes is restored.

What did you expect to happen?

After the deletion by SUPERADMIN, user1 should not have been allowed to save changes to deleted environment.

What else do we need to know?

[muralibasani]

@Divyanshu1998 Can you try with different browser profile windows ? If it's the same situation, we can look into.

Working with tabs in the same browser would not work due to session storage.

[Divyanshu1998]

Hi Murali,
I tried the same thing on different browser profiles(Mozilla Firefox and Chrome). I got the same bug when I delete the environment on one of the browser profile and edit on another browser profile.
In the addNewEnv(EnvModel env) method, when we do an edit to any environment there is no check for the deleted environment. It copies the fields into this env object and then manageDatabase.getHandleDbRequests().addNewEnv(env) line adds it into the database.I am referring to following lines of code in EnvsClustersTenantsControllerService.java file-

envActualList = envActualList.stream()
    .filter(env -> !env.getId().equals(newEnv.getId()))
    .collect(toList());

// Same name per type (kafka, kafkaconnect) in tenant not possible.
boolean envNameAlreadyPresent =
    envActualList.stream()
        .anyMatch(en ->
            en.getName().toLowerCase().equals(newEnv.getName().toLowerCase())
                && Objects.equals(en.getType(), newEnv.getType())
                && Objects.equals(en.getTenantId(), newEnv.getTenantId())
                && Objects.equals(en.getEnvExists(), "true"));
if (envNameAlreadyPresent) {
  return ApiResponse.notOk(ENV_CLUSTER_TNT_ERR_101);
}
//..
Env env = new Env();
copyProperties(newEnv, env);
env.setEnvExists("true");

String result = manageDatabase.getHandleDbRequests().addNewEnv(env);
if (result.equals(ApiResultStatus.SUCCESS.value)) {
  manageDatabase.addEnvToCache(tenantId, env, false);
  return ApiResponse.ok(result);
} else {
  return ApiResponse.notOk(result);
}
//..```

[muralibasani]

@Divyanshu1998 nice that you figured it out.
Would you like to open a PR for the same, to add that check you mentioned?

[Divyanshu1998]

@muralibasani Sure, I will do that.

[aindriu-aiven]

@muralibasani looks like we have a fix for this, can we close this ticket?

[muralibasani]

@aindriu-aiven the pr is still open, and waiting for @Divyanshu1998 to come back on it.

[Divyanshu1998]

@muralibasani @aindriu-aiven Sorry for the delay. I was busy with my college exams. Most likely I will fix the PR by today or tomorrow.

[aindriu-aiven]

@muralibasani @aindriu-aiven Sorry for the delay. I was busy with my college exams. Most likely I will fix the PR by today or tomorrow.

No worries at all I hope they went well!

[Divyanshu1998]

Hi @muralibasani
I have listed down potential issues(other than from the one already raised as bug) that are there in the application. Can you please verify these and let me know they are bugs or not. If needed I will push the fix for them-

1. Issue 1 (Concurrent Edits) - When two users edit the same environment, the user who saves last will have his edit overwrite the previous user write.
2. Issue 2 (Editing a cluster and deleting a cluster): Same issue as the current one.

If you feel these are issues then I have fix ready to be pushed(for current bug).