Skip to content

Commit 4821be9

Browse files
authored
Merge pull request #601 from Aiven-Open/jeqo/docs
chore: add config docs generation
2 parents 09865be + fa95272 commit 4821be9

File tree

15 files changed

+747
-72
lines changed

15 files changed

+747
-72
lines changed

.github/workflows/git.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,17 @@ jobs:
1010
- uses: actions/checkout@v3
1111
- name: Block Fixup Commit Merge
1212
uses: alexkappa/block-fixup-merge-action@v2
13+
14+
- name: Gen docs
15+
run: make docs
16+
17+
- name: Check for uncommitted changes
18+
run: |
19+
if [[ -n $(git status -s) ]]; then
20+
echo "There are uncommitted changes after the task:"
21+
git status -s
22+
exit 1
23+
else
24+
echo "No changes detected."
25+
fi
26+
shell: bash

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ storage/gcs/build/distributions/gcs-$(VERSION).tgz:
4242
storage/azure/build/distributions/azure-$(VERSION).tgz:
4343
./gradlew build :storage:azure:distTar -x test -x integrationTest -x e2e:test
4444

45+
.PHONY: docs
46+
docs:
47+
./gradlew :docs:genConfigDocs
48+
4549
test: build
4650
./gradlew test -x e2e:test
4751

commons/src/main/java/io/aiven/kafka/tieredstorage/config/validators/NonEmptyPassword.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,9 @@ public void ensureValid(final String name, final Object value) {
3333
throw new ConfigException(name + " value must not be empty");
3434
}
3535
}
36+
37+
@Override
38+
public String toString() {
39+
return "Non-empty password text";
40+
}
3641
}

commons/src/main/java/io/aiven/kafka/tieredstorage/config/validators/Null.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,10 @@ public void ensureValid(final String name, final Object value) {
4444
validator.ensureValid(name, value);
4545
}
4646
}
47+
48+
@Override
49+
public String toString() {
50+
return "null or " + validator.toString();
51+
}
4752
}
4853

commons/src/main/java/io/aiven/kafka/tieredstorage/config/validators/Subclass.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,9 @@ public void ensureValid(final String name, final Object value) {
4040
throw new ConfigException(name + " should be a subclass of " + parentClass.getCanonicalName());
4141
}
4242
}
43-
43+
44+
@Override
45+
public String toString() {
46+
return "Any implementation of " + parentClass.getName();
47+
}
4448
}

commons/src/main/java/io/aiven/kafka/tieredstorage/config/validators/ValidUrl.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,9 @@ public void ensureValid(final String name, final Object value) {
4343
}
4444
}
4545
}
46+
47+
@Override
48+
public String toString() {
49+
return "Valid URL as defined in rfc2396";
50+
}
4651
}

0 commit comments

Comments
 (0)