Skip to content

Conversation

jjaakola-aiven
Copy link
Contributor

No description provided.

@jjaakola-aiven jjaakola-aiven requested a review from a team as a code owner February 20, 2025 10:33
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-case-transform branch from 2c14ff1 to 4df98da Compare February 25, 2025 07:30
Copy link
Contributor

@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upper/lower case conversion is an issue the rest are suggestions or questions.

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-case-transform branch from 4df98da to c3d636c Compare February 25, 2025 10:10
@jjaakola-aiven jjaakola-aiven dismissed Claudenw’s stale review February 25, 2025 10:11

Addressed comments.

Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RyanSkraba RyanSkraba merged commit de2afac into master Mar 31, 2025
4 checks passed
@RyanSkraba RyanSkraba deleted the jjaakola-aiven-add-case-transform branch March 31, 2025 15:28
@RyanSkraba RyanSkraba mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants