feat: Add KeyToValue transform #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanSkraba
force-pushed
the
rskraba/KCON-136-keytovalue
branch
from
22b4077 to
d081c4b
Compare
Claudenw
reviewed
Apr 30, 2025
src/main/java/io/aiven/kafka/connect/transforms/KeyToValue.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/KeyToValue.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/KeyToValue.java
Outdated
Show resolved
Hide resolved
Claudenw
approved these changes
May 8, 2025
There was a problem hiding this comment.
Shouldn't this be KeyToValueConnectorTest rather than TestKeyToValueConnector?
There was a problem hiding this comment.
Ugh, this isn't a test :/
It needs a better name, or even optimised with a better strategy for all integration tests... Do you have any suggestions for the name for now? MockKeyToValueSource isn't quite right either :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new transformation that appends the key or selected key fields into the existing value.
This is similar to the existing standard Kafka transform ValueToKey, which replaces the existing key with fields from the value).