Skip to content

Commit 04f7eda

Browse files
refactor: reset型を正しく使う
1 parent ac37c09 commit 04f7eda

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/adat_tx.veryl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ pub module adat_tx #(
5151
var serial_bit : logic ;
5252
var serial_bit_valid : logic ;
5353
var serial_frame_done: logic ;
54-
var nrzi_rst : logic ;
55-
56-
assign nrzi_rst = ~i_rst;
5754

5855
// TimecodeやMIDIなどのユーザーデータは常に0とする
5956
// - U0: Timecode 常に0
@@ -108,7 +105,7 @@ pub module adat_tx #(
108105
// NRZIエンコード
109106
inst u_nrzi_encoder: tx_nrzi_encoder (
110107
i_clk ,
111-
i_rst : nrzi_rst ,
108+
i_rst ,
112109
i_bit : serial_bit ,
113110
i_valid: serial_bit_valid,
114111
o_nrzi : o_adat ,

src/tx_nrzi_encoder.veryl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
module tx_nrzi_encoder (
77
/// システムクロック
88
i_clk: input clock,
9-
/// アクティブハイリセット
10-
i_rst: input logic,
9+
/// リセット
10+
i_rst: input reset,
1111
/// シリアル入力ビット
1212
i_bit: input logic,
1313
/// 入力ビット有効
@@ -20,7 +20,7 @@ module tx_nrzi_encoder (
2020
assign o_nrzi = nrzi_level;
2121

2222
always_ff (i_clk) {
23-
if i_rst {
23+
if_reset {
2424
nrzi_level = 1'b0;
2525
} else if i_valid {
2626
if i_bit {
@@ -69,7 +69,7 @@ module tb_tx_nrzi_encoder;
6969

7070
initial begin
7171
pass = 1;
72-
rst = 1'b1;
72+
rst = 1'b0;
7373
bit_in = 1'b0;
7474
valid = 1'b0;
7575
expected_level = 1'b0;
@@ -80,7 +80,7 @@ module tb_tx_nrzi_encoder;
8080
pass = 0;
8181
end
8282

83-
rst = 1'b0;
83+
rst = 1'b1;
8484
@(posedge clk);
8585

8686
// 1で反転
@@ -120,12 +120,13 @@ module tb_tx_nrzi_encoder;
120120
end
121121

122122
// 再リセットで初期化
123-
rst = 1'b1;
123+
rst = 1'b0;
124124
@(posedge clk);
125125
if (nrzi !== 1'b0) begin
126126
$error("FAIL: reset should clear output to 0, got %b", nrzi);
127127
pass = 0;
128128
end
129+
rst = 1'b1;
129130

130131
if (pass) begin
131132
$display("*** TEST PASSED ***");

0 commit comments

Comments
 (0)