Skip to content

Commit b297b52

Browse files
committed
chore: lint
1 parent d80c98f commit b297b52

File tree

12 files changed

+87
-34
lines changed

12 files changed

+87
-34
lines changed

.eslintignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
node_modules/
22
dist/
3+
docs/
4+
docs-src/

.eslintrc.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
11
module.exports = {
22
root: true,
3-
parser: 'babel-eslint',
43
parserOptions: {
5-
sourceType: 'module'
4+
parser: 'babel-eslint',
5+
ecmaVersion: 2017,
6+
sourceType: 'module',
67
},
78
// https://github.com/feross/standard/blob/master/RULES.md#javascript-standard-style
8-
extends: 'standard',
9+
extends: [
10+
'standard',
11+
'plugin:vue/recommended',
12+
],
913
// required to lint *.vue files
14+
plugins: [
15+
'vue',
16+
],
1017
env: {
1118
browser: true,
1219
jest: true,
1320
},
1421
// add your custom rules here
15-
'rules': {
22+
rules: {
1623
// allow paren-less arrow functions
1724
'arrow-parens': 0,
1825
// allow async-await
@@ -24,5 +31,5 @@ module.exports = {
2431
// beware of returning assignement
2532
'no-return-assign': 'off',
2633
'no-extend-native': 'warn',
27-
}
34+
},
2835
}

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"dev": "cross-env NODE_ENV=development rollup --config build/rollup.config.es.js --watch",
1414
"prepublishOnly": "npm run test && npm run build",
1515
"test": "npm run test:types && npm run test:unit",
16+
"lint": "eslint . --ext .js,.vue",
1617
"test:unit": "vue-cli-service test:unit",
1718
"test:types": "cd ./tests/types && tsc --noEmit"
1819
},
@@ -53,6 +54,7 @@
5354
"eslint-plugin-node": "^11.1.0",
5455
"eslint-plugin-promise": "^4.1.1",
5556
"eslint-plugin-standard": "^5.0.0",
57+
"eslint-plugin-vue": "^7.4.0",
5658
"faker": "^4.1.0",
5759
"highlight.js": "^9.7.0",
5860
"jest": "^26.6.3",

src/components/Popover.vue

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
</div>
1515

1616
<div
17-
ref="popover"
1817
:id="popoverId"
18+
ref="popover"
1919
:class="[popoverBaseClass, popoverClass, cssClass]"
2020
:style="{
2121
visibility: isOpen ? 'visible' : 'hidden',
@@ -37,9 +37,15 @@
3737
/>
3838
</div>
3939

40-
<ResizeObserver v-if="handleResize" @notify="$_handleResize" />
40+
<ResizeObserver
41+
v-if="handleResize"
42+
@notify="$_handleResize"
43+
/>
4144
</div>
42-
<div ref="arrow" :class="popoverArrowClass"></div>
45+
<div
46+
ref="arrow"
47+
:class="popoverArrowClass"
48+
/>
4349
</div>
4450
</div>
4551
</div>
@@ -499,10 +505,10 @@ export default {
499505
500506
const events = typeof this.trigger === 'string'
501507
? this.trigger
502-
.split(' ')
503-
.filter(
504-
trigger => ['click', 'hover', 'focus'].indexOf(trigger) !== -1
505-
)
508+
.split(' ')
509+
.filter(
510+
trigger => ['click', 'hover', 'focus'].indexOf(trigger) !== -1,
511+
)
506512
: []
507513
508514
events.forEach(event => {
@@ -675,10 +681,12 @@ export default {
675681
676682
if (typeof document !== 'undefined' && typeof window !== 'undefined') {
677683
if (isIOS) {
678-
document.addEventListener('touchend', handleGlobalTouchend, supportsPassive ? {
679-
passive: true,
680-
capture: true,
681-
} : true)
684+
document.addEventListener('touchend', handleGlobalTouchend, supportsPassive
685+
? {
686+
passive: true,
687+
capture: true,
688+
}
689+
: true)
682690
} else {
683691
window.addEventListener('click', handleGlobalClick, true)
684692
}
@@ -695,7 +703,7 @@ function handleGlobalTouchend (event) {
695703
function handleGlobalClose (event, touch = false) {
696704
// Delay so that close directive has time to set values
697705
for (let i = 0; i < openPopovers.length; i++) {
698-
let popover = openPopovers[i]
706+
const popover = openPopovers[i]
699707
if (popover.$refs.popover) {
700708
const contains = popover.$refs.popover.contains(event.target)
701709
requestAnimationFrame(() => {

src/directives/v-close-popover.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ import { supportsPassive } from '../utils'
22

33
function addListeners (el) {
44
el.addEventListener('click', onClick)
5-
el.addEventListener('touchstart', onTouchStart, supportsPassive ? {
6-
passive: true,
7-
} : false)
5+
el.addEventListener('touchstart', onTouchStart, supportsPassive
6+
? {
7+
passive: true,
8+
}
9+
: false)
810
}
911

1012
function removeListeners (el) {

src/directives/v-tooltip.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import * as VTooltip from './v-tooltip'
2-
import { destroyTooltip } from './v-tooltip'
32

43
jest.mock('../lib/tooltip')
54

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function install (Vue, options = {}) {
1818

1919
Vue.directive('tooltip', vtooltip)
2020
Vue.directive('close-popover', vclosepopover)
21-
Vue.component('v-popover', Popover)
21+
Vue.component('VPopover', Popover)
2222
}
2323

2424
export const VTooltip = vtooltip

src/lib/tooltip.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,10 +630,12 @@ if (typeof document !== 'undefined') {
630630
for (let i = 0; i < openTooltips.length; i++) {
631631
openTooltips[i]._onDocumentTouch(event)
632632
}
633-
}, supportsPassive ? {
634-
passive: true,
635-
capture: true,
636-
} : true)
633+
}, supportsPassive
634+
? {
635+
passive: true,
636+
capture: true,
637+
}
638+
: true)
637639
}
638640

639641
/**

src/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export let supportsPassive = false
7070
if (typeof window !== 'undefined') {
7171
supportsPassive = false
7272
try {
73-
var opts = Object.defineProperty({}, 'passive', {
73+
const opts = Object.defineProperty({}, 'passive', {
7474
get () {
7575
supportsPassive = true
7676
},

tests/unit/.eslintrc.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
22
env: {
3-
jest: true
4-
}
5-
}
3+
jest: true,
4+
},
5+
}

0 commit comments

Comments
 (0)