fix(DynamicScroller): round height, closes #118

Guillaume Chau · Guillaume Chau · commit 760c8a38ad31 · 2019-02-19T15:29:52.000+01:00
diff --git a/src/components/DynamicScrollerItem.vue b/src/components/DynamicScrollerItem.vue
@@ -140,12 +140,13 @@ export default {
       this.$nextTick(() => {
         if (this.id === id) {
           const size = this.getSize()
-          if (size.height && this.height !== size.height) {
+          const height = Math.round(size.height)
+          if (height && this.height !== height) {
             if (this.vscrollBus.$_undefinedMap[id]) {
               this.vscrollBus.$_undefinedHeights--
               this.vscrollBus.$_undefinedMap[id] = undefined
             }
-            this.$set(this.vscrollData.heights, this.id, size.height)
+            this.$set(this.vscrollData.heights, this.id, height)
             if (this.emitResize) this.$emit('resize', this.id)
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -140,12 +140,13 @@ export default {`
`140`	`140`	`this.$nextTick(() => {`
`141`	`141`	`if (this.id === id) {`
`142`	`142`	`const size = this.getSize()`
`143`		`- if (size.height && this.height !== size.height) {`
	`143`	`+ const height = Math.round(size.height)`
	`144`	`+ if (height && this.height !== height) {`
`144`	`145`	`if (this.vscrollBus.$_undefinedMap[id]) {`
`145`	`146`	`this.vscrollBus.$_undefinedHeights--`
`146`	`147`	`this.vscrollBus.$_undefinedMap[id] = undefined`
`147`	`148`	`}`
`148`		`- this.$set(this.vscrollData.heights, this.id, size.height)`
	`149`	`+ this.$set(this.vscrollData.heights, this.id, height)`
`149`	`150`	`if (this.emitResize) this.$emit('resize', this.id)`
`150`	`151`	`}`
`151`	`152`	`}`