fix(core): iOS fix for navigation broken after showing modal over view already showing an alert dialog

farfromrefug · farfromrefug · commit 71bbb607d04f · 2025-09-30T11:08:34.000+02:00
diff --git a/packages/core/ui/page/index.ios.ts b/packages/core/ui/page/index.ios.ts
@@ -215,12 +215,13 @@ class UIViewControllerImpl extends UIViewController {
 			}
 		}
 
-		if (!this.presentedViewController) {
+		// TODO: testing without the check. Does not seem necessary and have very bad side effects.
+		// if (!this.presentedViewController) {
 			// clear presented viewController here only if no presented controller.
 			// this is needed because in iOS9 the order of events could be - willAppear, willDisappear, didAppear.
 			// If we clean it when we have viewController then once presented VC is dismissed then
 			owner._presentedViewController = null;
-		}
+		// }
 	}
 
 	@profile

Original file line number	Diff line number	Diff line change
`@@ -215,12 +215,13 @@ class UIViewControllerImpl extends UIViewController {`
`215`	`215`	`}`
`216`	`216`	`}`
`217`	`217`
`218`		`- if (!this.presentedViewController) {`
	`218`	`+ // TODO: testing without the check. Does not seem necessary and have very bad side effects.`
	`219`	`+ // if (!this.presentedViewController) {`
`219`	`220`	`// clear presented viewController here only if no presented controller.`
`220`	`221`	`// this is needed because in iOS9 the order of events could be - willAppear, willDisappear, didAppear.`
`221`	`222`	`// If we clean it when we have viewController then once presented VC is dismissed then`
`222`	`223`	`owner._presentedViewController = null;`
`223`		`- }`
	`224`	`+ // }`
`224`	`225`	`}`
`225`	`226`
`226`	`227`	`@profile`