--exclude-list-file not working

[rensvanleeuwen]

Describe the bug
The --exclude-list-file option does not exclude the file in my exclusion file. If use the inverse option --list-file it does.

cloc; OS; OS version

• cloc version: 1.98
• If running the cloc source, Perl version: -
• OS (eg Linux, Windows, macOS, etc): macOS
• OS version: 13.6.1

To Reproduce

I have created a small directory structure with some config and code:

❯ tree -a
.
├── .cloc-ignore
└── src
    └── net
        └── companies
            ├── CompaniesController.cs
            └── OtherCompaniesController.cs

4 directories, 3 files

With the .cloc-ignore containing:

❯ cat .cloc-ignore
./src/net/companies/CompaniesController.cs

When I run cloc without any file filtering, the following is shown:

❯ cloc . --quiet --by-file-by-lang
github.com/AlDanial/cloc v 1.98  T=0.01 s (164.9 files/s, 989.5 lines/s)
--------------------------------------------------------------------------------------------------
File                                                           blank        comment           code
--------------------------------------------------------------------------------------------------
./src/net/companies/CompaniesController.cs                         0              1              5
./src/net/companies/OtherCompaniesController.cs                    0              1              5
--------------------------------------------------------------------------------------------------
SUM:                                                               0              2             10
--------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C#                               2              0              2             10
-------------------------------------------------------------------------------
SUM:                             2              0              2             10
-------------------------------------------------------------------------------

Using the --list-file, you can see that the file in .cloc-ignore is filtered out:

❯ cloc . --quiet --by-file-by-lang --list-file=.cloc-ignore
github.com/AlDanial/cloc v 1.98  T=0.01 s (84.0 files/s, 503.9 lines/s)
---------------------------------------------------------------------------------------------
File                                                      blank        comment           code
---------------------------------------------------------------------------------------------
./src/net/companies/CompaniesController.cs                    0              1              5
---------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C#                               1              0              1              5
-------------------------------------------------------------------------------

However, using the inverse of that argument, I see all the files and nothing is filtered out:

❯ cloc . --quiet --by-file-by-lang --exclude-list-file=.cloc-ignore
github.com/AlDanial/cloc v 1.98  T=0.01 s (162.6 files/s, 975.9 lines/s)
--------------------------------------------------------------------------------------------------
File                                                           blank        comment           code
--------------------------------------------------------------------------------------------------
./src/net/companies/CompaniesController.cs                         0              1              5
./src/net/companies/OtherCompaniesController.cs                    0              1              5
--------------------------------------------------------------------------------------------------
SUM:                                                               0              2             10
--------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C#                               2              0              2             10
-------------------------------------------------------------------------------
SUM:                             2              0              2             10
-------------------------------------------------------------------------------

Expected result
The --exclude-list-file to filter out the defined files.

Additional context
I am currently using a --not-match-f as a workaround, but I prefer a more explicit/maintainable way for colleagues to easily add entries without having to know much about regexes.

[AlDanial]

Definitely a bug, thanks for reporting. Give dc4a3c5 a try.

[rensvanleeuwen]

That was quick, thank you :)

I have a local installation done with brew, an am not sure what the schedule is for releasing it. I'll sit tight and wait for it.

[AlDanial]

Sure, using brew is easy and convenient--but you will be waiting quite a while. Getting the dev version isn't much harder than using brew:

» wget https://github.com/AlDanial/cloc/raw/master/cloc
» chmod a+x cloc

[m0nters]

hey there, sorry for digging this up, but the command is still error here, im using the latest 2.6 version right now

[AlDanial]

yes, this is still an issue, investigating now

[AlDanial]

I was testing with an experimental version of cloc with some unresolved issues. If I use the production 2.06 version though, both --list-file and --exclude-list-file work as expected. @m0nters : give detailed steps on how to reproduce the problem you're seeing

[m0nters]

Hey there, I'm working with a small Vite React project, as you can see my .clocignore file includes node_modules, and I've declared it at the correct path in the root folder of the project, even my command prompt is cd at correct place, you can see the picture.

but when I run command cloc . --by-file-by-lang --exclude-list-file=.clocignore, it's like ignoring the .clocignore file and keeps counting, like you see in the picture it counts up to 5800 files which is not true if not including node_modules, my project obviously doesn't have too many files like that, so it means the --exclude-list-file command doesn't work

[m0nters]

Hi, I wanted to follow up on this issue. After waiting for some time for fun, I realized that the command DOES work and provides the correct analysis in the end, excluding the files I specified. However, it seems to read all files first before applying the exclusions, which significantly impacts performance. I have to wait for it to process everything, including the files that should be excluded.

So it might be worth for you guys to update the algorithm to exclude files from the start, rather than filtering them out after reading everything. Thanks!