Fix UPDATE on tables with PK when data is directly assigned to close #1989 (#2341)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: mathiasrw <[email protected]>

Author: Copilot

src/60createtable.js

@@ -574,14 +574,34 @@ yy.CreateTable.prototype.execute = function (databaseid, params, cb) {
 			pk = this.pk;
 			pk.pkaddr = pk.onrightfn(r, params);
 			if (typeof this.uniqs[pk.hh][pk.pkaddr] === 'undefined') {
-				throw new Error('Something wrong with index on table');
+				// If index is not populated (e.g., data was directly assigned), rebuild it.
+				// This allows UPDATE to work when data bypasses normal INSERT validation.
+				// Note: If data contains duplicate PKs, last occurrence wins (matches direct assignment semantics).
+				// This rebuild happens at most once per table since the index will be populated afterward.
+				this.uniqs[pk.hh] = {};
+				for (var j = 0; j < this.data.length; j++) {
+					var addr = pk.onrightfn(this.data[j]);
+					this.uniqs[pk.hh][addr] = this.data[j];
+				}
+				// Recalculate pkaddr after rebuilding
+				pk.pkaddr = pk.onrightfn(r, params);
 			}
 		}
 		if (table.uk && table.uk.length) {
 			table.uk.forEach(function (uk) {
 				uk.ukaddr = uk.onrightfn(r);
 				if (typeof table.uniqs[uk.hh][uk.ukaddr] === 'undefined') {
-					throw new Error('Something wrong with unique index on table');
+					// If index is not populated (e.g., data was directly assigned), rebuild it.
+					// This allows UPDATE to work when data bypasses normal INSERT validation.
+					// Note: If data contains duplicate unique keys, last occurrence wins (matches direct assignment semantics).
+					// This rebuild happens at most once per table since the index will be populated afterward.
+					table.uniqs[uk.hh] = {};
+					for (var j = 0; j < table.data.length; j++) {
+						var addr = uk.onrightfn(table.data[j]);
+						table.uniqs[uk.hh][addr] = table.data[j];
+					}
+					// Recalculate ukaddr after rebuilding
+					uk.ukaddr = uk.onrightfn(r);
 				}
 			});
 		}

test/test2318.js

@@ -0,0 +1,108 @@
+if (typeof exports === 'object') {
+	var assert = require('assert');
+	var alasql = require('..');
+}
+
+describe('Test 2318 - Update table with PK and direct data assignment', function () {
+	const test = '2318';
+
+	before(function () {
+		alasql('create database test' + test);
+		alasql('use test' + test);
+	});
+
+	after(function () {
+		alasql('drop database test' + test);
+	});
+
+	it('A) Update with no PK and direct assignment works', function () {
+		alasql('create table nopk (id int, name string)');
+		var db = alasql.databases['test' + test];
+		db.tables.nopk.data = [
+			{id: 1, name: 'Alice'},
+			{id: 2, name: 'Bob'},
+		];
+
+		var res = alasql('update nopk set name = ? where id = ?', ['Charlie', 1]);
+		assert.equal(res, 1);
+
+		var data = alasql('select * from nopk order by id');
+		assert.deepEqual(data, [
+			{id: 1, name: 'Charlie'},
+			{id: 2, name: 'Bob'},
+		]);
+	});
+
+	it('B) Update with PK and INSERT works', function () {
+		alasql('create table withpk (id int primary key, name string)');
+		alasql('insert into withpk values (1, ?)', ['Alice']);
+		alasql('insert into withpk values (2, ?)', ['Bob']);
+
+		var res = alasql('update withpk set name = ? where id = ?', ['Charlie', 1]);
+		assert.equal(res, 1);
+
+		var data = alasql('select * from withpk order by id');
+		assert.deepEqual(data, [
+			{id: 1, name: 'Charlie'},
+			{id: 2, name: 'Bob'},
+		]);
+	});
+
+	it('C) Update with PK and direct assignment should work', function () {
+		alasql('create table withpk2 (id int primary key, name string)');
+		var db = alasql.databases['test' + test];
+		db.tables.withpk2.data = [
+			{id: 1, name: 'Alice'},
+			{id: 2, name: 'Bob'},
+		];
+
+		// This should work but currently throws "Something wrong with index on table"
+		var res = alasql('update withpk2 set name = ? where id = ?', ['Charlie', 1]);
+		assert.equal(res, 1);
+
+		var data = alasql('select * from withpk2 order by id');
+		assert.deepEqual(data, [
+			{id: 1, name: 'Charlie'},
+			{id: 2, name: 'Bob'},
+		]);
+	});
+
+	it('D) Update with composite PK and direct assignment should work', function () {
+		alasql('create table composite (id1 int, id2 int, name string, primary key(id1, id2))');
+		var db = alasql.databases['test' + test];
+		db.tables.composite.data = [
+			{id1: 1, id2: 1, name: 'Alice'},
+			{id1: 1, id2: 2, name: 'Bob'},
+		];
+
+		var res = alasql('update composite set name = ? where id1 = ? and id2 = ?', ['Charlie', 1, 1]);
+		assert.equal(res, 1);
+
+		var data = alasql('select * from composite order by id1, id2');
+		assert.deepEqual(data, [
+			{id1: 1, id2: 1, name: 'Charlie'},
+			{id1: 1, id2: 2, name: 'Bob'},
+		]);
+	});
+
+	it('E) Update with UNIQUE constraint and direct assignment should work', function () {
+		alasql('create table withunique (id int, email string unique, name string)');
+		var db = alasql.databases['test' + test];
+		db.tables.withunique.data = [
+			{id: 1, email: '[email protected]', name: 'Alice'},
+			{id: 2, email: '[email protected]', name: 'Bob'},
+		];
+
+		var res = alasql('update withunique set name = ? where email = ?', [
+			'Charlie',
+			'[email protected]',
+		]);
+		assert.equal(res, 1);
+
+		var data = alasql('select * from withunique order by id');
+		assert.deepEqual(data, [
+			{id: 1, email: '[email protected]', name: 'Charlie'},
+			{id: 2, email: '[email protected]', name: 'Bob'},
+		]);
+	});
+});