Add NaN check to inline FK and test for NULL values with inline FKs

Co-authored-by: mathiasrw <[email protected]>

Author: Copilot

src/60createtable.js

@@ -173,15 +173,16 @@ yy.CreateTable.prototype.execute = function (databaseid, params, cb) {
 				};
 				var fkfn = function (r) {
 					var rr = {};
-					if (r[col.columnid] == null) {
-						return true;
-					}
-					rr[fk.columnid] = r[col.columnid];
-					var addr = fktable.pk.onrightfn(rr);
-					if (!fktable.uniqs[fktable.pk.hh][addr]) {
-						throw new Error(
-							'Foreign key "' + r[col.columnid] + '" not found in table "' + fk.tableid + '"'
-						);
+					var val = r[col.columnid];
+					// Only check foreign key if value is not null, undefined, or NaN
+					if (val != null && !(typeof val === 'number' && isNaN(val))) {
+						rr[fk.columnid] = val;
+						var addr = fktable.pk.onrightfn(rr);
+						if (!fktable.uniqs[fktable.pk.hh][addr]) {
+							throw new Error(
+								'Foreign key "' + val + '" not found in table "' + fk.tableid + '"'
+							);
+						}
 					}
 					return true;
 				};

test/test1643.js

@@ -345,4 +345,28 @@ describe('Test 1643 - Foreign Key and Primary Key Column Detection', function ()
 		var table = db.tables.InlineChild;
 		assert(table.xcolumns.ParentId.foreignkey, 'ParentId should have foreignkey property');
 	});
+
+	it('L) Inline foreign key should allow NULL values', function () {
+		alasql('DROP TABLE IF EXISTS InlineNullChild');
+		alasql('DROP TABLE IF EXISTS InlineNullParent');
+
+		alasql(`CREATE TABLE InlineNullParent (
+			Id INT PRIMARY KEY
+		)`);
+
+		alasql(`CREATE TABLE InlineNullChild (
+			ChildId INT PRIMARY KEY,
+			ParentId INT FOREIGN KEY REFERENCES InlineNullParent(Id)
+		)`);
+
+		alasql('INSERT INTO InlineNullParent VALUES (1)');
+
+		// Insert with NULL foreign key should succeed (NULL is allowed)
+		var res = alasql('INSERT INTO InlineNullChild VALUES (1, NULL)');
+		assert.equal(res, 1, 'Insert with NULL inline foreign key should succeed');
+
+		// Insert with valid foreign key should succeed
+		var res2 = alasql('INSERT INTO InlineNullChild VALUES (2, 1)');
+		assert.equal(res2, 1, 'Insert with valid inline foreign key should succeed');
+	});
 });