Skip to content

Commit f6e298b

Browse files
authored
Fix JOIN on JSONL sources
- Fix: when join JSONL source, "ReferenceError: res is not defined" error will be thrown - Improve: make the user code possible to capture & handle errors from JSON & JSONL source
1 parent 286abe3 commit f6e298b

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

src/84from.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,12 @@ alasql.from.JSON = function (filename, opts, cb, idx, query) {
133133
}
134134
}),
135135
err => {
136-
throw new Error(err);
136+
const error = err instanceof Error ? err : new Error(err);
137+
if(query && query.cb) {
138+
query.cb(null, error);
139+
return;
140+
}
141+
throw error;
137142
};
138143
return res;
139144
};
@@ -158,11 +163,16 @@ const jsonl = ext => {
158163
}
159164
});
160165
if (cb) {
161-
res = cb(out, idx, query);
166+
out = cb(out, idx, query);
162167
}
163168
},
164169
err => {
165-
throw new Error(err);
170+
const error = err instanceof Error ? err : new Error(err);
171+
if(query && query.cb) {
172+
query.cb(null, error);
173+
return;
174+
}
175+
throw error;
166176
}
167177
);
168178
return out;

0 commit comments

Comments
 (0)