Backend's ID_KEY might be None

Signed-off-by: Rick Elrod <[email protected]>

Author: relrod

ansible_base/authentication/utils/authentication.py

@@ -96,9 +96,13 @@ def check_system_username(uid: str) -> None:
 
 def determine_username_from_uid_social(**kwargs) -> dict:
     uid_field = getattr(kwargs.get('backend', None), 'ID_KEY', 'username')
+    if uid_field is None:
+        uid_field = 'username'
     selected_username = kwargs.get('details', {}).get(uid_field, None)
     if not selected_username:
-        raise AuthException(_('Unable to get associated username from: %(details)s') % {'details': kwargs.get("details", None)})
+        raise AuthException(
+            _('Unable to get associated username from attribute {uid_field}: %(details)s') % {'uid_field': uid_field, 'details': kwargs.get("details", None)}
+        )
 
     authenticator = kwargs.get('backend')
     if not authenticator:

test_app/tests/authentication/utils/test_authentication.py

@@ -1,3 +1,5 @@
+from types import SimpleNamespace
+
 import pytest
 from django.conf import settings
 from social_core.exceptions import AuthException
@@ -197,3 +199,17 @@ def test_determine_username_from_uid_social_happy_path(self, ldap_authenticator)
             uid="Bob",
         )
         assert response == {'username': 'Bob'}
+
+    @pytest.mark.parametrize(
+        "kwargs,expected_uid_field",
+        [
+            ({}, 'username'),
+            ({'backend': None}, 'username'),
+            ({'backend': SimpleNamespace(ID_KEY='testing')}, 'testing'),
+            ({'backend': SimpleNamespace(ID_KEY=None)}, 'testing'),
+        ],
+    )
+    def test_determine_username_from_uid_social_authenticator_ID_KEY(self, kwargs, expected_uid_field):
+        with pytest.raises(AuthException) as ae:
+            authentication.determine_username_from_uid_social(**kwargs)
+            assert f'Unable to get associated username from attribute {expected_uid_field}' in ae