AAP-39554 fix black (ansible#690)

# [[AAP-39554](https://issues.redhat.com/browse/AAP-39554)] Fix new
version of black breaking linting

## Description
<!-- Mandatory: Provide a clear, concise description of the changes and
their purpose -->
- What is being changed?
We are pinning to a version of black, flake8 and isort.
We are updating old code that no longer works with the pinned version of
black

- Why is this change needed?
Black released a new version and some old code now needs changes to
accommodate its new rules.
We are pinning black so that this will not affect us in the future.

- How does this change address the issue?
With the change to the code, the codebase is now compliant with the new
rules for black.
Pinning black will mean that we will not automatically get new versions
of black so existing code will remain compliant.
We will have to manually update black in the future if we want to.

## Type of Change
<!-- Mandatory: Check one or more boxes that apply -->
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update
- [ ] Test update
- [X] Refactoring (no functional changes)
- [X] Development environment change
- [X] Configuration change

## Self-Review Checklist
<!-- These items help ensure quality - they complement our automated CI
checks -->
- [X] I have performed a self-review of my code
- [X] I have added relevant comments to complex code sections
- [X] I have updated documentation where needed
- [X] I have considered the security impact of these changes
- [X] I have considered performance implications
- [X] I have thought about error handling and edge cases
- [X] I have tested the changes in my local environment

## Testing Instructions
<!-- Optional for test-only changes. Mandatory for all other changes -->
<!-- Must be detailed enough for reviewers to reproduce -->
### Prerequisites
<!-- List any specific setup required -->

### Steps to Test
1. 
2. 
3. 

### Expected Results
<!-- Describe what should happen after following the steps -->

## Additional Context
<!-- Optional but helpful information -->

### Required Actions
<!-- Check if changes require work in other areas -->
<!-- Remove section if no external actions needed -->
- [ ] Requires documentation updates
  <!-- API docs, feature docs, deployment guides -->
- [ ] Requires downstream repository changes
  <!-- Specify repos: django-ansible-base, eda-server, etc. -->
- [ ] Requires infrastructure/deployment changes
  <!-- CI/CD, installer updates, new services -->
- [ ] Requires coordination with other teams
  <!-- UI team, platform services, infrastructure -->
- [ ] Blocked by PR/MR: #XXX
  <!-- Reference blocking PRs/MRs with brief context -->

### Screenshots/Logs
<!-- Add if relevant to demonstrate the changes -->

Author: john-westcott-iv

pyproject.toml

@@ -131,19 +131,19 @@ legacy_tox_ini = """
 
     [testenv:flake8]
     deps =
-        flake8
-        Flake8-pyproject
+        flake8==7.1.1
+        Flake8-pyproject==1.2.3
     commands = flake8 {posargs:.}
 
     [testenv:black]
     deps =
-        black
+        black==25.1.0
     allowlist_externals = sh
     commands = sh -c 'black --version && black {posargs:.}'
 
     [testenv:isort]
     deps =
-        isort
+        isort==6.0.0
     commands = isort {posargs:.}
 """
 

requirements/requirements_dev.txt

@@ -1,11 +1,15 @@
-ansible  # Used in build process to generate some configs
+ansible                 # Used in build process to generate some configs
+black==25.1.0           # Linting tool, if changed update pyproject.toml as well
 build
 django==4.2.17
 django-debug-toolbar
 django-extensions
 djangorestframework
 django-split-settings
+flake8==7.1.1           # Linting tool, if changed update pyproject.toml as well
+Flake8-pyproject==1.2.3 # Linting tool, if changed update pyproject.toml as well
 ipython
+isort==6.0.0            # Linting tool, if changed update pyproject.toml as well
 tox
 tox-docker
 typeguard

test_app/models.py

@@ -170,6 +170,7 @@ class LogEntry(models.Model):
 
 class Inventory(models.Model):
     "Simple example of a child object, it has a link to its parent organization"
+
     name = models.CharField(max_length=512)
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, null=True, related_name='inventories')
     credential = models.ForeignKey('test_app.Credential', on_delete=models.SET_NULL, null=True, related_name='inventories')
@@ -195,6 +196,7 @@ def validate_role_assignment(self, actor, role_definition, **kwargs):
 
 class Credential(models.Model):
     "Example of a model that gets used by other models"
+
     name = models.CharField(max_length=512)
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, null=True, related_name='credentials')
 
@@ -209,28 +211,33 @@ def summary_fields(self):
 
 class InstanceGroup(models.Model):
     "Example of an object with no parent object, a root resource, a lone wolf"
+
     name = models.CharField(max_length=512)
 
 
 class Namespace(models.Model):
     "Example of a child object with its own child objects"
+
     name = models.CharField(max_length=64, unique=True, blank=False)
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='namespaces')
 
 
 class CollectionImport(models.Model):
     "Example of a child of a child object, organization is implied by its namespace"
+
     name = models.CharField(max_length=64, unique=True, blank=False)
     namespace = models.ForeignKey(Namespace, on_delete=models.CASCADE, related_name='collections')
 
 
 class ExampleEvent(models.Model):
     "Example of a model which is not registered in permission registry in the first place"
+
     name = models.CharField(max_length=64, unique=True, blank=False)
 
 
 class Cow(models.Model):
     "This model has a special action it can do, which is to give advice"
+
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='cows')
 
     class Meta:
@@ -241,6 +248,7 @@ class Meta:
 
 class UUIDModel(models.Model):
     "Tests that system works with a model that has a string uuid primary key"
+
     id = models.UUIDField(primary_key=True, default=uuid.uuid4)
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='uuidmodels')
 
@@ -285,17 +293,20 @@ class Meta:
 
 class ParentName(models.Model):
     "Tests that system works with a parent field name different from parent model name"
+
     my_organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='parentnames')
 
 
 class PositionModel(models.Model):
     "Uses a primary key other than id to test that everything still works"
+
     position = models.BigIntegerField(primary_key=True)
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='positionmodels')
 
 
 class WeirdPerm(models.Model):
     "Uses a weird permission name"
+
     organization = models.ForeignKey(Organization, on_delete=models.CASCADE, related_name='weirdperms')
 
     class Meta:
@@ -320,6 +331,7 @@ class Meta:
 
 class Original1(NamedCommonModel):
     "Registered with the Resource Registry"
+
     pass
 
 
@@ -332,6 +344,7 @@ class Meta:
 
 class Original2(NamedCommonModel):
     "Not registered"
+
     pass