Reduce tests some

Author: AlanCoding

test_app/tests/rbac/test_migrations.py

@@ -44,19 +44,9 @@ def test_cleanup_orphaned_permissions_deletes_unregistered_unreferenced():
     # Create a DABContentType for a model not in the permission registry
     dab_fake_ct = DABContentType.objects.create(app_label='fake_app', model='fakemodel', service='local')
 
-    # Create a permission for this fake model
+    # Create a permission for this fake model (should be deleted)
     orphaned_permission = DABPermission.objects.create(name='Can view fake model', content_type=dab_fake_ct, codename='view_fakemodel')
 
-    # For registered model, let's use an existing DABContentType from the test setup
-    # Get any existing DABContentType that represents a registered model
-    existing_registered_ct = DABContentType.objects.filter(app_label='test_app').first()
-
-    if not existing_registered_ct:
-        # Create one if none exist
-        existing_registered_ct = DABContentType.objects.create(app_label='test_app', model='organization', service='shared')
-
-    valid_permission = DABPermission.objects.create(name='Can view registered model', content_type=existing_registered_ct, codename='view_registered')
-
     initial_count = DABPermission.objects.count()
 
     # Run cleanup
@@ -66,7 +56,6 @@ def test_cleanup_orphaned_permissions_deletes_unregistered_unreferenced():
     assert deleted_count == 1
     assert DABPermission.objects.count() == initial_count - 1
     assert not DABPermission.objects.filter(id=orphaned_permission.id).exists()
-    assert DABPermission.objects.filter(id=valid_permission.id).exists()
 
 
 @pytest.mark.django_db
@@ -94,56 +83,3 @@ def test_cleanup_orphaned_permissions_preserves_referenced():
     assert deleted_count == 0
     assert DABPermission.objects.count() == initial_count
     assert DABPermission.objects.filter(id=referenced_permission.id).exists()
-
-
-@pytest.mark.django_db
-def test_cleanup_orphaned_permissions_preserves_registered():
-    """Test that cleanup_orphaned_permissions preserves all permissions for registered models.
-
-    Generated by Claude Sonnet 4 (claude-sonnet-4@20250514)
-    """
-    initial_count = DABPermission.objects.count()
-
-    # Run cleanup - should not delete any existing permissions since they're for registered models
-    deleted_count = cleanup_orphaned_permissions(apps)
-
-    # Verify no permissions were deleted
-    assert deleted_count == 0
-    assert DABPermission.objects.count() == initial_count
-
-
-@pytest.mark.django_db
-def test_cleanup_orphaned_permissions_mixed_scenario():
-    """Test cleanup with a mix of registered, unregistered referenced, and unregistered unreferenced permissions.
-
-    Generated by Claude Sonnet 4 (claude-sonnet-4@20250514)
-    """
-    # Create DABContentTypes for models not in the permission registry
-    dab_fake_ct1 = DABContentType.objects.create(app_label='fake_app', model='orphanedmodel', service='local')
-    dab_fake_ct2 = DABContentType.objects.create(app_label='fake_app', model='referencedmodel', service='local')
-
-    # Create orphaned permission (should be deleted)
-    orphaned_permission = DABPermission.objects.create(name='Can view orphaned model', content_type=dab_fake_ct1, codename='view_orphanedmodel')
-
-    # Create referenced permission (should be preserved)
-    referenced_permission = DABPermission.objects.create(name='Can view referenced model', content_type=dab_fake_ct2, codename='view_referencedmodel')
-
-    # Create a RoleDefinition that references the second permission
-    role_def = RoleDefinition.objects.create(name='Referenced Role', content_type=dab_fake_ct2)
-    role_def.permissions.add(referenced_permission)
-
-    # Get count of valid permissions (for registered models)
-    valid_perms_count = DABPermission.objects.exclude(id__in=[orphaned_permission.id, referenced_permission.id]).count()
-
-    initial_count = DABPermission.objects.count()
-
-    # Run cleanup
-    deleted_count = cleanup_orphaned_permissions(apps)
-
-    # Verify only the orphaned permission was deleted
-    assert deleted_count == 1
-    assert DABPermission.objects.count() == initial_count - 1
-    assert not DABPermission.objects.filter(id=orphaned_permission.id).exists()
-    assert DABPermission.objects.filter(id=referenced_permission.id).exists()
-    # All other permissions should still exist
-    assert DABPermission.objects.exclude(id=referenced_permission.id).count() == valid_perms_count