AAP-42306 Revert ansible#623 Do not intercept is_superuser JWT auth (ansible#867)

Makes gateway the  source of truth for is_superuser

Allows it to be synced to other components via JWT authentication

Author: bhavenst

ansible_base/jwt_consumer/common/auth.py

@@ -133,8 +133,6 @@ def parse_jwt_token(self, request):
             except IntegrityError as exc:
                 logger.debug(f'Existing user {self.token["user_data"]} is a conflict with local user, error: {exc}')
                 with no_reverse_sync():
-                    if user_defaults['is_superuser'] is False:
-                        user_defaults.pop('is_superuser')
                     self.user, created = get_user_model().objects.update_or_create(
                         username=self.token["user_data"]['username'],
                         defaults=user_defaults,
@@ -174,8 +172,6 @@ def map_user_fields(self):
                         "Please make sure the sync task is running to prevent this warning in the future."
                     )
                     continue
-                if attribute == 'is_superuser' and new_value is False:
-                    continue
                 logger.debug(f"Changing {attribute} for {self.user.username} from {old_value} to {new_value}")
                 setattr(self.user, attribute, new_value)
                 user_needs_save = True

test_app/tests/jwt_consumer/common/test_auth.py

@@ -642,7 +642,7 @@ def test_authenticate(self, jwt_token, django_user_model, mocked_http, test_encr
     @pytest.mark.django_db()
     @pytest.mark.parametrize(
         "original_is_superuser, token_is_superuser, expected_is_superuser",
-        [(True, False, True), (False, True, True), (True, True, True), (False, False, False)],
+        [(True, False, False), (False, True, True), (True, True, True), (False, False, False)],
     )
     def test_authenticate_is_superuser(
         self, jwt_token, django_user_model, mocked_http, test_encryption_public_key, original_is_superuser, token_is_superuser, expected_is_superuser