Review comments to consistently use is_rbac_installed

Author: AlanCoding

ansible_base/authentication/utils/claims.py

@@ -960,10 +960,9 @@ def cache_existing(self, role_assignments: Iterable[models.Model]) -> None:
             - Role definitions are also cached separately in self.role_definitions
         """
         local_resource_prefixes = ["shared"]
-        if is_rbac_installed():
-            from ansible_base.rbac.remote import get_local_resource_prefix
+        from ansible_base.rbac.remote import get_local_resource_prefix  # RBAC must be installed to use method
 
-            local_resource_prefixes.append(get_local_resource_prefix())
+        local_resource_prefixes.append(get_local_resource_prefix())
 
         for role_assignment in role_assignments:
             # Cache role definition

ansible_base/lib/routers/association_resource_router.py

@@ -3,7 +3,6 @@
 from itertools import chain
 from typing import Type
 
-from django.conf import settings
 from django.db.models import Model
 from django.db.models.fields import IntegerField
 from django.db.models.query import QuerySet
@@ -17,6 +16,8 @@
 from rest_framework.response import Response
 from rest_framework.viewsets import ViewSetMixin
 
+from ansible_base.lib.utils.apps import is_rbac_installed
+
 logger = logging.getLogger('ansible_base.lib.routers.association_resource_router')
 
 
@@ -117,7 +118,7 @@ def check_parent_object_permissions(self, request, parent_obj: Model) -> None:
         will not check "change" permissions to the parent object on POST
         this method checks parent change permission, view permission should be handled by filter_queryset
         """
-        if (request.method not in SAFE_METHODS) and 'ansible_base.rbac' in settings.INSTALLED_APPS:
+        if (request.method not in SAFE_METHODS) and is_rbac_installed():
             from ansible_base.rbac.permission_registry import permission_registry
 
             if permission_registry.is_registered(parent_obj):