Skip to content

Commit ad8a93e

Browse files
committed
Do concrete action decoroators
1 parent 2eb90c9 commit ad8a93e

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

ansible_base/rbac/service_api/views.py

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ def remote_secondary_sync_unassignment(self, role_definition, actor, content_obj
5959
"To allow service-specific sync when removing an assignment via this viewset"
6060
pass
6161

62-
@action(detail=False, methods=['post'], url_path='assign')
63-
def assign(self, request):
62+
def _assign(self, request):
6463
serializer = self.get_serializer(data=request.data)
6564
serializer.is_valid(raise_exception=True)
6665

@@ -74,8 +73,7 @@ def assign(self, request):
7473
output_serializer = self.get_serializer(instance)
7574
return Response(output_serializer.data, status=status.HTTP_201_CREATED)
7675

77-
@action(detail=False, methods=['post'], url_path='unassign')
78-
def unassign(self, request):
76+
def _unassign(self, request):
7977
serializer = self.get_serializer(data=request.data)
8078
serializer.is_valid(raise_exception=True)
8179

@@ -116,6 +114,14 @@ class ServiceRoleUserAssignmentViewSet(BaseSerivceRoleAssignmentViewSet):
116114
]
117115
)
118116

117+
@action(detail=False, methods=['post'], url_path='assign')
118+
def assign(self, request):
119+
return self._assign(request)
120+
121+
@action(detail=False, methods=['post'], url_path='unassign')
122+
def unassign(self, request):
123+
return self._unassign(request)
124+
119125

120126
class ServiceRoleTeamAssignmentViewSet(
121127
AnsibleBaseDjangoAppApiView,
@@ -135,3 +141,11 @@ class ServiceRoleTeamAssignmentViewSet(
135141
HasResourceRegistryPermissions,
136142
]
137143
)
144+
145+
@action(detail=False, methods=['post'], url_path='assign')
146+
def assign(self, request):
147+
return self._assign(request)
148+
149+
@action(detail=False, methods=['post'], url_path='unassign')
150+
def unassign(self, request):
151+
return self._unassign(request)

0 commit comments

Comments
 (0)