Refactor the whole thing to do a save override

Author: AlanCoding

ansible_base/rbac/models.py

@@ -389,18 +389,14 @@ class Meta:
         app_label = 'dab_rbac'
         abstract = True
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
-        # Fields from object_role are cached onto assignment objects, only when creating new assignments
-        # we must be very careful to avoid referencing deferred attributes to avoid RecursionError
-        def_fields = self.get_deferred_fields()
-        if not ({'id', 'object_id', 'object_role_id'} & def_fields):
-            if (not self.id) and self.object_role_id and (not self.object_id):
+    def save(self, *args, **kwargs):
+        if not self.id:  # usually only new objects can be saved, but super needs to do error handling
+            if self.object_role_id and (not self.object_id):
                 # Cache fields from the associated object_role
                 self.object_id = self.object_role.object_id
                 self.content_type_id = self.object_role.content_type_id
                 self.role_definition_id = self.object_role.role_definition_id
+        return super().save(*args, **kwargs)
 
 
 class RoleUserAssignment(AssignmentBase):