Skip to content

Commit b96e64f

Browse files
authored
[Alt 1] Flip default of reverse sync to True (ansible#618)
While revisiting ansible/eda-server#1061, I realized that `RESOURCE_SERVER_SYNC_ENABLED` is not set to True. This will not work to do what we want. As of ansible#603, for any practical system (excluding test_app specifically here), we will be safe to have a True value.
1 parent 4a38ba0 commit b96e64f

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

ansible_base/lib/dynamic_config/settings_logic.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,10 @@ def get_dab_settings(
226226
dab_data['ORG_ADMINS_CAN_SEE_ALL_USERS'] = True
227227

228228
if 'ansible_base.resource_registry' in installed_apps:
229-
dab_data['RESOURCE_SERVER_SYNC_ENABLED'] = False
229+
# Sync local changes to the resource server
230+
# This will not do anything if RESOURCE_SERVER is not defined
231+
dab_data['RESOURCE_SERVER_SYNC_ENABLED'] = True
232+
# The API path on the resource server to use to update resources
230233
dab_data['RESOURCE_SERVICE_PATH'] = "/api/gateway/v1/service-index/"
231234

232235
# Disable legacy SSO by default

test_app/settings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,9 @@
197197
"VALIDATE_HTTPS": False,
198198
}
199199
RESOURCE_SERVICE_PATH = "/api/v1/service-index/"
200+
# Backwards sync turned off, because for most of the duration of the tests
201+
# the resource server will not actually be running
202+
# so it will be flipped true only for specific tests that test this
200203
RESOURCE_SERVER_SYNC_ENABLED = False
201204

202205
RENAMED_USERNAME_PREFIX = "dab:"

0 commit comments

Comments
 (0)