Avoid content type model method in migrations

Author: AlanCoding

ansible_base/rbac/management/__init__.py

@@ -80,8 +80,8 @@ def sync_dab_permissions(verbosity=2, using=DEFAULT_DB_ALIAS, apps=global_apps):
     This should make the database content reflect the model Meta data and
     registrations in the permission_registry for that app.
     """
-    dab_ct_cls = apps.get_model("dab_rbac", "DABContentType")
     Permission = apps.get_model("dab_rbac", "DABPermission")
+    dab_ct_cls = Permission._meta.get_field('content_type').related_model
 
     new_cts = create_DAB_contenttypes(verbosity=verbosity, using=using, apps=apps)
 

ansible_base/rbac/management/create_types.py

@@ -5,7 +5,7 @@
 from django.db import DEFAULT_DB_ALIAS, connection, models
 
 from ansible_base.rbac import permission_registry
-from ansible_base.rbac.remote import get_resource_prefix
+from ansible_base.rbac.remote import get_resource_prefix, get_local_resource_prefix, get_remote_standin_class
 
 logger = logging.getLogger(__name__)
 
@@ -17,6 +17,14 @@ def get_local_dab_contenttypes(using: str, ct_model: Type[models.Model]) -> dict
     return {(ct.service, ct.model): ct for ct in ct_model.objects.using(using)}
 
 
+def model_class(apps, ct):
+    "Model methods normally can not be used in migrations so this is a safer utility method"
+    if ct.service not in ("shared", get_local_resource_prefix()):
+        return get_remote_standin_class(ct)
+
+    return apps.get_model(ct.app_label, ct.model)
+
+
 def create_DAB_contenttypes(
     verbosity=2,
     using=DEFAULT_DB_ALIAS,
@@ -74,10 +82,11 @@ def create_DAB_contenttypes(
 
     updated_ct = 0
     for ct in dab_ct_cls.objects.all():
-        if not permission_registry.is_registered(ct.model_class()):
+        ct_model_class = model_class(apps, ct)
+        if not permission_registry.is_registered(ct_model_class):
             logger.warning(f'{ct.model} is a stale content type in DAB RBAC')
             continue
-        if parent_model := permission_registry.get_parent_model(ct.model_class()):
+        if parent_model := permission_registry.get_parent_model(ct_model_class):
             parent_content_type = dab_ct_cls.objects.get_for_model(parent_model)
             if ct.parent_content_type != parent_content_type:
                 ct.parent_content_type = parent_content_type