Isolate test that does reload to fix cross-talk failure

Author: AlanCoding

ansible_base/authentication/authenticator_plugins/ldap.py

@@ -363,7 +363,7 @@ def validate(self, attrs):
 class LDAPSettings(BaseLDAPSettings):
     def __init__(self, prefix: str = 'AUTH_LDAP_', defaults: dict = {}):
         # This init method double checks the passed defaults while initializing a settings objects
-        super(LDAPSettings, self).__init__(prefix, defaults)
+        super().__init__(prefix, defaults)
 
         # SERVER_URI needs to be a string, not an array
         setattr(self, 'SERVER_URI', ','.join(defaults['SERVER_URI']))

test_app/tests/authentication/authenticator_plugins/test_ldap.py

@@ -1,4 +1,3 @@
-import importlib
 from collections import OrderedDict
 from unittest import mock
 from unittest.mock import MagicMock
@@ -680,27 +679,3 @@ def test_ldap_user_search_validation(
 )
 def test_ldap_search_field_is_single_search(value, expected_result):
     assert LDAPSearchField.is_single_search(value) is expected_result
-
-
-@pytest.mark.django_db
-@pytest.mark.parametrize(
-    "username",
-    [
-        ("Timmy"),
-        ("TIMMY"),
-        ("TiMmY"),
-    ],
-)
-def test_get_or_build_user(username, ldap_authenticator):
-    from ansible_base.authentication.authenticator_plugins import ldap
-
-    with mock.patch(
-        'ansible_base.authentication.utils.authentication.get_or_create_authenticator_user', return_value=(None, None, None)
-    ) as get_or_create_authenticator_user:
-        importlib.reload(ldap)
-        plugin = AuthenticatorPlugin(database_instance=ldap_authenticator)
-        ldap_object = MagicMock()
-        plugin.get_or_build_user(username, ldap_object)
-        assert get_or_create_authenticator_user.called
-        assert username.lower() in get_or_create_authenticator_user.call_args[0]
-        assert username not in get_or_create_authenticator_user.call_args[0]

test_app/tests/authentication/authenticator_plugins/test_ldap_get_or_build_user.py

@@ -0,0 +1,29 @@
+import importlib
+from unittest import mock
+from unittest.mock import MagicMock
+
+import pytest
+
+from ansible_base.authentication.authenticator_plugins import ldap
+
+
+@pytest.mark.django_db
+@pytest.mark.parametrize(
+    "username",
+    [
+        ("Timmy"),
+        ("TIMMY"),
+        ("TiMmY"),
+    ],
+)
+def test_get_or_build_user(username, ldap_authenticator):
+    with mock.patch(
+        'ansible_base.authentication.utils.authentication.get_or_create_authenticator_user', return_value=(None, None, None)
+    ) as get_or_create_authenticator_user:
+        importlib.reload(ldap)
+        plugin = ldap.AuthenticatorPlugin(database_instance=ldap_authenticator)
+        ldap_object = MagicMock()
+        plugin.get_or_build_user(username, ldap_object)
+        assert get_or_create_authenticator_user.called
+        assert username.lower() in get_or_create_authenticator_user.call_args[0]
+        assert username not in get_or_create_authenticator_user.call_args[0]