Fix double assignment

Author: AlanCoding

ansible_base/rbac/management/create_types.py

@@ -66,8 +66,6 @@ def create_DAB_contenttypes(
                 current_max_id = dab_ct_cls.objects.order_by('-id').values_list('id', flat=True).first() or 0
                 ct_item_data['id'] = current_max_id + 1
             ct_data.append(ct_item_data)
-    if not ct_data:
-        return []
 
     # Create the items here
     cts = []
@@ -78,6 +76,7 @@ def create_DAB_contenttypes(
         for ct in cts:
             logger.debug("Adding DAB content type " f"'{ct.service}:{ct.app_label} | {ct.model}'")
 
+    # Update, or set for the first time, the parent type reference
     updated_ct = 0
     for ct in dab_ct_cls.objects.all():
         ct_model_class = model_class(apps, ct)

ansible_base/rbac/migrations/0005_remote_permissions_data.py

@@ -10,7 +10,7 @@ def create_types_if_needed(apps, schema_editor):
     Only needed in the upgrade case, otherwise better to run at true post-migrate.
     """
     permission_cls = apps.get_model('dab_rbac', 'DABPermission')
-    rd_cls = permission_cls = apps.get_model('dab_rbac', 'RoleDefinition')
+    rd_cls = apps.get_model('dab_rbac', 'RoleDefinition')
     if permission_cls.objects.exists() or rd_cls.objects.exists():
         from ansible_base.rbac.management.create_types import create_DAB_contenttypes