Skip to content

Commit 8982cdd

Browse files
authored
fix: pr workflow not running (#14)
1 parent 446c087 commit 8982cdd

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

.github/workflows/pr.yml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,21 @@ jobs:
3131
# We already run the current golangci-lint in tests, but here we test
3232
# our GitHub action with the latest stable golangci-lint.
3333
# **Important**: The v1 version of the action on GitHub does not support golang 1.25, so it needs to be disabled.
34-
# golangci-lint:
35-
# runs-on: ubuntu-latest
36-
# steps:
37-
# - uses: actions/checkout@v4
38-
# - uses: actions/setup-go@v5
39-
# with:
40-
# # https://github.com/actions/setup-go#supported-version-syntax
41-
# # ex:
42-
# # - 1.18beta1 -> 1.18.0-beta.1
43-
# # - 1.18rc1 -> 1.18.0-rc.1
44-
# go-version: ${{ env.GO_VERSION }}
45-
# - name: lint
46-
# uses: golangci/[email protected]
47-
# with:
48-
# version: latest
34+
golangci-lint:
35+
runs-on: ubuntu-latest
36+
steps:
37+
- uses: actions/checkout@v4
38+
- uses: actions/setup-go@v5
39+
with:
40+
# https://github.com/actions/setup-go#supported-version-syntax
41+
# ex:
42+
# - 1.18beta1 -> 1.18.0-beta.1
43+
# - 1.18rc1 -> 1.18.0-rc.1
44+
go-version: ${{ env.GO_VERSION }}
45+
# - name: lint
46+
# uses: golangci/[email protected]
47+
# with:
48+
# version: latest
4949

5050
tests-on-windows:
5151
needs: golangci-lint # run after golangci-lint action to not produce duplicated errors

test/run_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
275275
},
276276
target: "quicktemplate",
277277
expected: []string{
278-
"testdata/quicktemplate/hello.qtpl.go:10:1: package-comments: should have a package comment (revive)",
279278
"testdata/quicktemplate/hello.qtpl.go:26:1: exported: exported function StreamHello should have comment or be unexported (revive)",
280279
"testdata/quicktemplate/hello.qtpl.go:39:1: exported: exported function WriteHello should have comment or be unexported (revive)",
281280
"testdata/quicktemplate/hello.qtpl.go:50:1: exported: exported function Hello should have comment or be unexported (revive)",
@@ -290,7 +289,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
290289
},
291290
target: "quicktemplate",
292291
expected: []string{
293-
"testdata/quicktemplate/hello.qtpl.go:10:1: package-comments: should have a package comment (revive)",
294292
"testdata/quicktemplate/hello.qtpl.go:26:1: exported: exported function StreamHello should have comment or be unexported (revive)",
295293
"testdata/quicktemplate/hello.qtpl.go:39:1: exported: exported function WriteHello should have comment or be unexported (revive)",
296294
"testdata/quicktemplate/hello.qtpl.go:50:1: exported: exported function Hello should have comment or be unexported (revive)",

0 commit comments

Comments
 (0)