Skip to content

Commit 7f04fc3

Browse files
authored
fix: update script execution from sh to bash in sonarqube ingress OIDC deploy feature (#38)
1 parent 93d734f commit 7f04fc3

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

.tekton/dockerfile/Dockerfile.base

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM docker-mirrors.alauda.cn/library/openjdk:17-jdk-slim
1+
FROM docker-mirrors.alauda.cn/library/openjdk:26-ea-17-jdk-slim-bookworm
22

33
WORKDIR /app
44

@@ -34,4 +34,4 @@ RUN set -eux; \
3434
./bin/yq --version && \
3535
./bin/kubectl version --client && \
3636
./bin/helm version && \
37-
jq --version
37+
jq --version

testing/Dockerfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ WORKDIR /app
55
COPY . /app
66

77
ENV GOPROXY='https://build-nexus.alauda.cn/repository/golang/,direct'
8+
RUN PWGO_VER=$(grep -oE "playwright-go v\S+" /app/testing/go.mod | sed 's/playwright-go //g') \
9+
&& go install github.com/playwright-community/playwright-go/cmd/playwright@${PWGO_VER}
810
RUN set -eux \
911
&& mkdir -p /tools/bin && chmod -R 777 /tools/bin \
1012
&& cd /app/testing \
@@ -20,6 +22,9 @@ RUN set -eux \
2022
COPY --chown=nonroot:nonroot ./chart /app/chart
2123
COPY --chown=nonroot:nonroot ./testing /app/testing
2224
COPY --chown=nonroot:nonroot --from=builder /tools/bin/sonarqube-e2e.test /app/bin/sonarqube-e2e.test
25+
COPY --chown=nonroot:nonroot --from=builder /go/bin/playwright /app/bin/playwright
26+
27+
RUN /app/bin/playwright install chromium --with-deps
2328

2429
WORKDIR /app/testing
2530

testing/features/sonarqube-ingress-oidc-deploy.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
@automated
88
@priority-high
99
@allure.label.case_id:sonarqube-operator-deploy-sso
10-
场景: 通过默认配置部署 Sonarqube
10+
场景: 部署 Sonarqube 并使用 OIDC 认证
1111
并且 集群已存在存储类
1212
并且 命名空间 "testing-sonarqube-sso-operator" 已存在
1313
并且 已导入 "SonarQube 数据库" 资源: "./testdata/resources/pg-postgresql.yaml"
@@ -18,7 +18,7 @@
1818
并且 已导入 "pvc" 资源: "./testdata/resources/sonarqube-pvc.yaml"
1919
并且 执行 "sso 配置" 脚本成功
2020
| command |
21-
| sh ./scripts/prepare-sso-config.sh '<config.{{.acp.baseUrl}}>' '<config.{{.acp.token}}>' '<config.{{.acp.cluster}}>' testing-sonarqube-sso-operator http://<node.ip.random.readable>:<nodeport.http> |
21+
| bash ./scripts/prepare-sso-config.sh '<config.{{.acp.baseUrl}}>' '<config.{{.acp.token}}>' '<config.{{.acp.cluster}}>' testing-sonarqube-sso-operator http://<node.ip.random.readable>:<nodeport.http> |
2222
| mkdir -p output/images |
2323
已导入 "sonarqube 实例" 资源
2424
"""

testing/steps/sso.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func process(ctx context.Context, ssoParams ssoParams) (ctx2 context.Context, er
107107
}
108108

109109
if err := loginSonarqube(ctx, page, ssoParams); err != nil {
110-
log.Error("Sonarqube 登录失败: %v", zap.Error(err))
110+
log.Error("Sonarqube 登录失败: ", zap.Error(err))
111111
return ctx, err
112112
}
113113

@@ -134,7 +134,7 @@ func loginACP(ctx context.Context, page playwright.Page, params ssoParams) error
134134
log.Info("等待登录表单出现...")
135135
if _, err := page.WaitForSelector(".login-form", playwright.PageWaitForSelectorOptions{
136136
State: playwright.WaitForSelectorStateVisible,
137-
Timeout: playwright.Float(30000),
137+
Timeout: playwright.Float(60000),
138138
}); err != nil {
139139
return fmt.Errorf("等待登录表单: %v", err)
140140
}
@@ -189,7 +189,7 @@ func loginSonarqube(ctx context.Context, page playwright.Page, params ssoParams)
189189
log.Info("等待 Log in with OpenID Connect 按钮出现...")
190190
if err := page.Locator("#oauth-providers").WaitFor(playwright.LocatorWaitForOptions{
191191
State: playwright.WaitForSelectorStateVisible,
192-
Timeout: playwright.Float(30000),
192+
Timeout: playwright.Float(60000),
193193
}); err == nil {
194194
found = true
195195
break
@@ -208,8 +208,10 @@ func loginSonarqube(ctx context.Context, page playwright.Page, params ssoParams)
208208

209209
// Wait for page load to complete
210210
if err := page.WaitForLoadState(playwright.PageWaitForLoadStateOptions{
211-
State: playwright.LoadStateNetworkidle,
211+
State: playwright.LoadStateNetworkidle,
212+
Timeout: playwright.Float(60000),
212213
}); err != nil {
214+
log.Error("等待页面加载完成失败", zap.Error(err))
213215
return err
214216
}
215217

0 commit comments

Comments
 (0)