Final v1.4.4 push; bugfixes

- finished "AboutVersion"
- fixed bug resulting in the action tester not working (not being included in the build)
- the start window not showing automatically for new users
- fixed "move_mouse" action

Author: AlbertMN

Advanced Installer/Advanced Installer-SetupFiles/ACCsetup.exe

@@ -140,6 +140,7 @@
     <ROW File="Spanish.json" Component_="Danish.json" FileName="SPANIS~1.JSO|Spanish.json" Attributes="0" SourcePath="..\AssistantComputerControl\Translations\Spanish.json" SelfReg="false"/>
     <ROW File="PortugueseBrasil.json" Component_="Danish.json" FileName="PORTUG~1.JSO|Portuguese - Brasil.json" Attributes="0" SourcePath="..\AssistantComputerControl\Translations\Portuguese - Brasil.json" SelfReg="false"/>
     <ROW File="Dutch.json" Component_="Danish.json" FileName="DUTCH~1.JSO|Dutch.json" Attributes="0" SourcePath="..\AssistantComputerControl\Translations\Dutch.json" SelfReg="false"/>
+    <ROW File="ActionTester.html" Component_="AboutVersion.html" FileName="ACTION~1.HTM|ActionTester.html" Attributes="0" SourcePath="..\AssistantComputerControl\WebFiles\ActionTester.html" SelfReg="false"/>
   </COMPONENT>
   <COMPONENT cid="caphyon.advinst.msicomp.AppPathsComponent">
     <ROW Name="AI_APPPATH_PERBUILD_AssistantComputerControl.exe" Path="[|AI_PROPPATH_DIR_PERBUILD_AssistantComputerControl.exe]\[|AI_PROPPATH_FILENAME_PERBUILD_AssistantComputerControl.exe]" Type="2" Content="0"/>

Advanced Installer/Advanced Installer-cache/cacheIndex.txt

@@ -1,7 +1,7 @@
 /*
  * AssistantComputerControl
  * Made by Albert MN.
- * Updated: v1.4.2, 12-12-2020
+ * Updated: v1.4.4, 19-05-2021
  * 
  * Use:
  * - Functions for all the actions
@@ -1051,20 +1051,23 @@ public void MoveMouse(String parameter) {
         public const int MOUSEEVENTF_MIDDLEDOWN = 0x20;
         public const int MOUSEEVENTF_MIDDLEUP = 0x40;
 
-        public void MouseClick(string parameter = "", string secondaryParameter = "") {
+        public void MouseClick(string parameter = "") {
             /*
              * Action made by community member Joshua Miller (modified by Albert)
              */
 
+            string firstParameter = parameter != null && parameter != String.Empty ? ActionChecker.GetSecondaryParam(parameter)[0] : "",
+                secondParameter = parameter != null && parameter != String.Empty ? (ActionChecker.GetSecondaryParam(parameter).Length > 1 ? ActionChecker.GetSecondaryParam(parameter)[1] : null) : "";
+
             int timesToClick = 1;
-            string type = parameter;
+            string type = firstParameter;
 
-            if (parameter == String.Empty) {
+            if (firstParameter == String.Empty) {
                 type = "left";
             }
 
-            if (secondaryParameter != String.Empty) {
-                if (Int32.TryParse(secondaryParameter, out int repeatAmount)) {
+            if (secondParameter != String.Empty && secondParameter != null) {
+                if (Int32.TryParse(secondParameter, out int repeatAmount)) {
                     timesToClick = repeatAmount;
                 } else {
                     Error("Secondary parameter (how many times to click) is not a valid number");

Advanced Installer/Advanced Installer.aip

@@ -1,7 +1,7 @@
 /*
  * AssistantComputerControl
  * Made by Albert MN.
- * Updated: v1.4.4, 08-05-2021
+ * Updated: v1.4.4, 19-05-2021
  * 
  * Use:
  * - Main class. Starts everything.
@@ -28,7 +28,7 @@
 namespace AssistantComputerControl {
     class MainProgram {
         public const string softwareVersion = "1.4.4",
-            releaseDate = "2021-05-19 00:05:00", //YYYY-MM-DD H:i:s - otherwise it gives an error
+            releaseDate = "2021-05-19 20:59:00", //YYYY-MM-DD H:i:s - otherwise it gives an error
             appName = "AssistantComputerControl",
 
             sentryToken = "super_secret";
@@ -286,12 +286,9 @@ void ActualMain() {
                     key = key.OpenSubKey("AssistantComputerControl", true);
                     key.SetValue("FirstTime", false);
 
-                    Properties.Settings.Default.HasCompletedTutorial = true;
-                    Properties.Settings.Default.Save();
-
                     ShowGettingStarted();
 
-                    DoDebug("Starting setup guide");
+                    DoDebug("Starting setup guide (first time opening ACC - wuhu!)");
                 } else {
                     if (!Properties.Settings.Default.HasCompletedTutorial) {
                         ShowGettingStarted();
@@ -321,7 +318,6 @@ void ActualMain() {
 
                         SetStartup(true);
                     } else {
-                        //Make sure the startup is up to date (fixed task errors in 1.4.4, for example)
                         if (ACCStartsWithWindows()) {
                             SetStartup(true);
                         }
@@ -662,6 +658,14 @@ public static void SetStartup(bool status, bool setThroughSoftware = false) {
                     //Try start with Task Scheduler;
                     var userId = WindowsIdentity.GetCurrent().Name;
 
+                    try {
+                        //Try to delete first; make sure it's gone before attempting to re-create it
+                        using (TaskService ts = new TaskService()) {
+                            ts.RootFolder.DeleteTask(@"AssistantComputerControl startup");
+                        }
+                    } catch {
+                    }
+
                     using (var ts = new TaskService()) {
                         var td = ts.NewTask();
                         td.RegistrationInfo.Author = "Albert MN. | AssistantComputerControl";
@@ -857,7 +861,7 @@ public static string CheckPath(bool noDefaultCheck = false) {
                 if ((Properties.Settings.Default.HasCompletedTutorial && gettingStarted is null && !hasAskedForSetupAgain)) {
                     //Cloud service path not found & no custom filepath, go through setup again?
                     hasAskedForSetupAgain = true;
-                    var msgBox = MessageBox.Show(Translator.__("no_cloudservice_chosen", "general"), "[ERROR] No folder specified | AssistantComputerControl", MessageBoxButtons.YesNo);
+                    var msgBox = MessageBox.Show("TEST" + Translator.__("no_cloudservice_chosen", "general"), "[ERROR] No folder specified | AssistantComputerControl", MessageBoxButtons.YesNo);
                     if (msgBox == DialogResult.Yes) {
                         ShowGettingStarted();
                     }

AssistantComputerControl/Actions.cs

@@ -37,10 +37,11 @@
                     <i>Version 1.4.4 hotfix notes;</i>
                     <ul>
                         <li class="mb-2">Fixed <b>start with windows</b> bug on laptops <i>(when not charging, and made ACC close when charging stopped...)</i> - big thanks to community member BricioEs02 for helping debug this</li>
-                        <li class="mb-2">Fixed <code>mouse_click</code> action only allowing left clicks <i>(parameters didn't work)</i></li>
+                        <li class="mb-2">Fixed <code>mouse_click</code> action only allowing left clicks <i>(parameters didn't work)</i> and secondary parameter <i>(amount of times to click)</i> also not working</li>
                         <li class="mb-2">Fixed bug that made the update checker able to crash the software if no network was available</li>
                         <li class="mb-2">Added <code>ignoreme</code> "action", which can be used to have a line in an action file ignored <i>(most won't get a use out of this, but an article on why this is useful for some is coming out soon)</i></li>
                         <li class="mb-2">Added extra safety to "start with windows", so that there's now two ways of setting it; if the first one fails, it'll try the second <i>(automatically - nothing to do with the user)</i></li>
+                        <li class="mb-2">Fixed issue that resulted in the "action tester" not being included in the install</li>
                         <li>Sorry for all the updates - the v1.4.2 update just broke a lot of things apparently</li>
                     </ul>
                 </li>

AssistantComputerControl/MainProgram.cs

@@ -1,7 +1,7 @@
 /*
  * AssistantComputerControl
  * Made by Albert MN.
- * Updated: v1.4.0, 15-01-2020
+ * Updated: v1.4.4, 19-05-2021
  * 
  * Use:
  * - Checks and execute action files