Merge pull request #3555 from AlchemyCMS/use-numeric-http-status-codes

Replace HTTP status code symbols with numeric codes

Author: tvdeyen

app/controllers/alchemy/admin/attachments_controller.rb

@@ -52,13 +52,13 @@ def show
 
       def create
         @attachment = Attachment.create(attachment_attributes)
-        handle_uploader_response(status: :created)
+        handle_uploader_response(status: 201)
       end
 
       def update
         @attachment.update(attachment_attributes)
         if attachment_attributes["file"].present?
-          handle_uploader_response(status: :accepted)
+          handle_uploader_response(status: 202)
         else
           render_errors_or_redirect(
             @attachment,

app/controllers/alchemy/admin/base_controller.rb

@@ -111,7 +111,7 @@ def render_errors_or_redirect(object, redirect_url, flash_notice)
           do_redirect_to redirect_url
         else
           render action: ((params[:action] == "update") ? "edit" : "new"),
-            status: :unprocessable_entity
+            status: 422
         end
       end
 

app/controllers/alchemy/admin/elements_controller.rb

@@ -41,11 +41,11 @@ def create
           end
         end
         if @element.save
-          render :create, status: :created
+          render :create, status: 201
         else
           @element.page_version = @page_version
           @elements = @page.available_element_definitions
-          render :new, status: :unprocessable_entity
+          render :new, status: 422
         end
       end
 
@@ -74,7 +74,7 @@ def update
                 errorMessage: ingredient.errors.messages[:value].to_sentence
               }
             end
-          }, status: :unprocessable_entity
+          }, status: 422
         end
       end
 

app/controllers/alchemy/admin/layoutpages_controller.rb

@@ -26,7 +26,7 @@ def update
           @while_page_edit = request.referer.include?("edit")
           render "alchemy/admin/pages/update"
         else
-          render :edit, status: :unprocessable_entity
+          render :edit, status: 422
         end
       end
 

app/controllers/alchemy/admin/legacy_page_urls_controller.rb

@@ -22,7 +22,7 @@ def update
         @message = message_for_resource_action
         render :update
       else
-        render :edit, status: :unprocessable_entity
+        render :edit, status: 422
       end
     end
 

app/controllers/alchemy/admin/nodes_controller.rb

@@ -34,20 +34,20 @@ def create
               flash_notice_for_resource_action(:create)
               do_redirect_to(admin_nodes_path)
             else
-              render :new, status: :unprocessable_entity
+              render :new, status: 422
             end
           rescue => e
             flash[:error] = e.message
             new  # Reinitialize instance variables like @node
-            render :new, status: :unprocessable_entity
+            render :new, status: 422
           end
         else
           @node = Node.new(resource_params)
           if @node.save
             flash_notice_for_resource_action(:create)
             do_redirect_to(admin_nodes_path)
           else
-            render :new, status: :unprocessable_entity
+            render :new, status: 422
           end
         end
       end

app/controllers/alchemy/admin/pages_controller.rb

@@ -139,7 +139,7 @@ def update
             flash[:notice] = @notice
           end
         else
-          render :configure, status: :unprocessable_entity
+          render :configure, status: 422
         end
       end
 
@@ -175,7 +175,7 @@ def fold
             if was_folded
               @page = PageTreePreloader.new(page: @page, user: current_alchemy_user).call
             else
-              head :ok
+              head 200
             end
           end
         end

app/controllers/alchemy/admin/pictures_controller.rb

@@ -89,7 +89,7 @@ def update
             type: "error"
           }
         end
-        render :update, status: (@message[:type] == "notice") ? :ok : :unprocessable_entity
+        render :update, status: (@message[:type] == "notice") ? 200 : 422
       end
 
       def update_multiple

app/controllers/alchemy/base_controller.rb

@@ -54,7 +54,7 @@ def permission_denied(exception = nil)
         WARN
       end
       if request.format.json?
-        render json: {message: Alchemy.t("You are not authorized")}, status: :unauthorized
+        render json: {message: Alchemy.t("You are not authorized")}, status: 401
       elsif current_alchemy_user
         handle_redirect_for_user
       else

app/controllers/alchemy/pages_controller.rb

@@ -157,7 +157,7 @@ def page_locale_redirect_url(options = {})
 
     # Redirects to given url with 301 status
     def redirect_permanently_to(url)
-      redirect_to url, status: :moved_permanently
+      redirect_to url, status: 301
     end
 
     # Returns url parameters that are not internal show page params.