fix(PictureDescriptionSelect): Add site name to identifier

In a multi site environment, the languages have the
same code. Adding the site name helps to identify the
language per site.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

Author: tvdeyen

app/components/alchemy/admin/picture_description_select.rb

@@ -38,7 +38,8 @@ def language_options
       end
 
       def language_label(language)
-        language.code.upcase
+        language_name = language.name
+        multi_site? ? "#{language_name} (#{language.site.name})" : language_name
       end
     end
   end

spec/components/alchemy/admin/picture_description_select_spec.rb

@@ -27,7 +27,24 @@
       end
 
       it "renders the select box with both languages" do
-        expect(page).to have_select("Language", options: ["EN", "DE"], selected: "EN")
+        expect(page).to have_select("Language", options: ["English", "Deutsch"], selected: "English")
+        expect(page).to have_selector("alchemy-picture-description-select[url='/some/url']")
+      end
+    end
+
+    context "when there are multiple sites" do
+      let!(:language) { create(:alchemy_language, :english, site: site1) }
+      let!(:german) { create(:alchemy_language, :german, site: site2) }
+      let(:site1) { create(:alchemy_site, host: "demo.example.com", name: "Demo") }
+      let(:site2) { create(:alchemy_site, host: "www.example.com", name: "Default") }
+
+      before do
+        allow_any_instance_of(described_class).to receive(:multi_site?).and_return(true)
+        render
+      end
+
+      it "renders select with site names" do
+        expect(page).to have_select("Language", options: ["English (Demo)", "Deutsch (Default)"], selected: "English (Demo)")
         expect(page).to have_selector("alchemy-picture-description-select[url='/some/url']")
       end
     end

spec/features/admin/picture_library_integration_spec.rb

@@ -231,16 +231,16 @@
         expect(page).to have_content("Picture updated successfully")
       end
 
-      select(german.language_code.upcase, from: "Language")
+      select(german.name, from: "Language")
       fill_in "Description", with: "Tolles Bild."
       click_button "Save"
       within "#flash_notices" do
         expect(page).to have_content("Picture updated successfully")
       end
 
-      select(language.language_code.upcase, from: "Language")
+      select(language.name, from: "Language")
       expect(page).to have_field("Description", with: "This is an amazing image.")
-      select(german.language_code.upcase, from: "Language")
+      select(german.name, from: "Language")
       expect(page).to have_field("Description", with: "Tolles Bild.")
     end
   end