Merge pull request #3517 from AlchemyCMS/only-draft-element-assignments

fix(assignments): Only list draft elements

Author: tvdeyen

app/controllers/alchemy/admin/attachments_controller.rb

@@ -37,7 +37,7 @@ def index
 
       # The resources controller renders the edit form as default for show actions.
       def show
-        @assignments = @attachment.related_ingredients.joins(element: :page)
+        @assignments = @attachment.related_ingredients.joins(element: :page).merge(PageVersion.drafts)
         render :show
       end
 

app/controllers/alchemy/admin/pictures_controller.rb

@@ -43,7 +43,7 @@ def show
         @previous = @pictures.prev_page
         @next = @pictures.next_page
 
-        @assignments = @picture.related_ingredients.joins(element: :page)
+        @assignments = @picture.related_ingredients.joins(element: :page).merge(PageVersion.drafts)
         @picture_description = @picture.descriptions.find_or_initialize_by(
           language_id: Alchemy::Current.language.id
         )

spec/controllers/alchemy/admin/attachments_controller_spec.rb

@@ -95,6 +95,21 @@ module Alchemy
         get :show, params: {id: attachment.id}
         expect(response).to render_template(:show)
       end
+
+      context "with assignments" do
+        let!(:page) { create(:alchemy_page) }
+        let!(:element) { create(:alchemy_element, page: page) }
+        let!(:ingredient) { create(:alchemy_ingredient_file, element: element, related_object: attachment) }
+
+        before do
+          page.publish!
+        end
+
+        it "assigns all file ingredients having an assignment to @assignments" do
+          get :show, params: {id: attachment.id}
+          expect(assigns(:assignments)).to eq([ingredient])
+        end
+      end
     end
 
     describe "#create" do

spec/controllers/alchemy/admin/pictures_controller_spec.rb

@@ -179,6 +179,10 @@ module Alchemy
         let!(:element) { create(:alchemy_element, page: page) }
         let!(:ingredient) { create(:alchemy_ingredient_picture, element: element, related_object: picture) }
 
+        before do
+          page.publish!
+        end
+
         it "assigns all picture ingredients having an assignment to @assignments" do
           get :show, params: {id: picture.id}
           expect(assigns(:assignments)).to eq([ingredient])