Convert auth accessors to configuration object#3418
Merged
tvdeyen merged 3 commits intoAlchemyCMS:mainfrom Jan 27, 2026
Merged
Conversation
mamhoff
force-pushed
the
auth-configuration
branch
3 times, most recently
from
d5c9603 to
954e985
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
+ Coverage 97.44% 97.46% +0.01%
==========================================
Files 314 314
Lines 8194 8218 +24
==========================================
+ Hits 7985 8010 +25
+ Misses 209 208 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
auth-configuration
branch
from
954e985 to
8645785
Compare
tvdeyen
reviewed
Oct 11, 2025
mamhoff
force-pushed
the
auth-configuration
branch
2 times, most recently
from
c6d73b9 to
74d6166
Compare
Contributor
Author
|
Rebased on #3424 in order to get the |
mamhoff
force-pushed
the
auth-configuration
branch
from
74d6166 to
a85e1b4
Compare
tvdeyen
reviewed
Oct 15, 2025
tvdeyen
reviewed
Oct 16, 2025
mamhoff
force-pushed
the
auth-configuration
branch
2 times, most recently
from
e1adfda to
43681c3
Compare
|
This pull request has not seen any activiy in a long time. |
Member
|
@mamhoff this needs a rebase and conflict resolution. |
mamhoff
force-pushed
the
auth-configuration
branch
2 times, most recently
from
d13264a to
20a4bdb
Compare
tvdeyen
reviewed
Dec 28, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks for rebasing. I think we should get rid of the extra auth class. It is unnecessary imo.
mamhoff
force-pushed
the
auth-configuration
branch
4 times, most recently
from
e80ebb2 to
1b0afb4
Compare
If `Alchemy.user_class` is `nil`, which it is in case of an invalid configuration, it's not a class, and we can't use the `<` operator. Let's use duck typing instead.
This allows us to do ``` Alchemy.configure do |config| config.user_class = "Spree::User" end ```
mamhoff
force-pushed
the
auth-configuration
branch
from
1b0afb4 to
1ff562b
Compare
Creates a configuration object for authentication that can be initialized outside of a `config.to_prepare` block. Configuration is now in `Alchemy.config`.
mamhoff
force-pushed
the
auth-configuration
branch
from
1ff562b to
afb581f
Compare
tvdeyen
approved these changes
Jan 27, 2026
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Amazing work. Would be great to update the alchemy.rb.tt install file to the new configurations.
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This converts the
auth_accessors.rbmodule, which is purely configuration, to a configuration object.All methods are still there, but deprecated, and a few accessors stay in
lib/alchemy.rbas shortcuts.Notable changes (remove if none)
We can now configure Alchemy's auth system entirely outside of a
config.to_prepareblock.Checklist