Skip to content

Commit a94bce7

Browse files
authored
Merge pull request #4 from AlchemyViewer/rye/winsym
Fix embedded debug symbols on windows
2 parents abec48b + dd7685a commit a94bce7

File tree

3 files changed

+29
-13
lines changed

3 files changed

+29
-13
lines changed

autobuild.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
<key>archive</key>
1717
<map>
1818
<key>hash</key>
19-
<string>db512fb9036db60e702990bc652487197a0e6c1542de6d35163368f07e8f5d0c21f74071c2c2d3b70ee10f28b2e4717dd340196d7656e1fd515f7a4a07bfc6d9</string>
19+
<string>ea8354aedf732fab3ae7e2931d493175c78f426657d465356b1d04ca75eee2e47dc5fca8910b6d2093819e8bfffab661a63803bee9eaabd1401860bf47b5c0fd</string>
2020
<key>hash_algorithm</key>
2121
<string>blake2b</string>
2222
<key>url</key>
23-
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r2/zlib_ng-2.2.4.13482737442-darwin64-13482737442.tar.zst</string>
23+
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r3/zlib_ng-2.2.4.13485424982-darwin64-13485424982.tar.zst</string>
2424
</map>
2525
<key>name</key>
2626
<string>darwin64</string>
@@ -30,11 +30,11 @@
3030
<key>archive</key>
3131
<map>
3232
<key>hash</key>
33-
<string>7062d4f650e7cca63061d3d5675cc17615adfe5e0b6dd7acdf203e48650bda62af8a741e51bac7bb0725476652f68cf28fa958a87f18e75a78ad3eb7a3df8c27</string>
33+
<string>c123a43db118c5b44b99e299a98aa29f0d58edb3f5b874d6877770d0a95f53b99201cf03746381b9d506fcea2701f8a029854a3d30f4a4614e182e9ef88f0ff0</string>
3434
<key>hash_algorithm</key>
3535
<string>blake2b</string>
3636
<key>url</key>
37-
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r2/zlib_ng-2.2.4.13482737442-linux64-13482737442.tar.zst</string>
37+
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r3/zlib_ng-2.2.4.13485424982-linux64-13485424982.tar.zst</string>
3838
</map>
3939
<key>name</key>
4040
<string>linux64</string>
@@ -44,11 +44,11 @@
4444
<key>archive</key>
4545
<map>
4646
<key>hash</key>
47-
<string>4984b3df1bc9bbce36a5be9ef7410d2387c81653e99beec57785a0961acfca2ebbbbfef9acbbcaae7f2f7a6c1ae708d99cd8d7b2d6aa71d79900694d809b4aba</string>
47+
<string>52c2e385869d2ae4189eec525dc3980756a3d0acc74cae5754bf5c6441766a2c40b3b1fe25146ded8754581c3ad22638df52db67ff530f49d9160351ada3986c</string>
4848
<key>hash_algorithm</key>
4949
<string>blake2b</string>
5050
<key>url</key>
51-
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r2/zlib_ng-2.2.4.13482737442-windows64-13482737442.tar.zst</string>
51+
<string>https://github.com/AlchemyViewer/3p-zlib-ng/releases/download/v2.2.4-r3/zlib_ng-2.2.4.13485424982-windows64-13485424982.tar.zst</string>
5252
</map>
5353
<key>name</key>
5454
<string>windows64</string>
@@ -61,7 +61,7 @@
6161
<key>copyright</key>
6262
<string>Copyright (C) 1995-2024 Jean-loup Gailly and Mark Adler</string>
6363
<key>version</key>
64-
<string>2.2.4.13482737442</string>
64+
<string>2.2.4.13485424982</string>
6565
<key>name</key>
6666
<string>zlib-ng</string>
6767
<key>canonical_repo</key>

build-cmd.sh

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ source_environment_tempfile="$stage/source_environment.sh"
3030
"$autobuild" source_environment > "$source_environment_tempfile"
3131
. "$source_environment_tempfile"
3232

33-
# remove_cxxstd
33+
# remove_cxxstd apply_patch
3434
source "$(dirname "$AUTOBUILD_VARIABLES_FILE")/functions"
3535

36+
apply_patch "$top/patches/update-cmake-version-compat.patch" "$MINIZLIB_SOURCE_DIR"
37+
3638
# CMake configuration options for all platforms
3739
config=( \
3840
-DBUILD_SHARED_LIBS=OFF \
@@ -64,8 +66,8 @@ pushd "$MINIZLIB_SOURCE_DIR"
6466
opts="$(replace_switch /Zi /Z7 $LL_BUILD_DEBUG)"
6567
plainopts="$(remove_switch /GR $(remove_cxxstd $opts))"
6668

67-
cmake $(cygpath -m ${top}/${MINIZLIB_SOURCE_DIR}) -G "Ninja Multi-Config" \
68-
-DCMAKE_BUILD_TYPE="Debug" \
69+
cmake $(cygpath -m ${top}/${MINIZLIB_SOURCE_DIR}) -G "$AUTOBUILD_WIN_CMAKE_GEN" -A "$AUTOBUILD_WIN_VSPLATFORM" \
70+
-DCMAKE_CONFIGURATION_TYPES="Debug" \
6971
-DCMAKE_C_FLAGS:STRING="$plainopts" \
7072
-DCMAKE_CXX_FLAGS:STRING="$opts" \
7173
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT="Embedded" \
@@ -90,8 +92,8 @@ pushd "$MINIZLIB_SOURCE_DIR"
9092
opts="$(replace_switch /Zi /Z7 $LL_BUILD_RELEASE)"
9193
plainopts="$(remove_switch /GR $(remove_cxxstd $opts))"
9294

93-
cmake $(cygpath -m ${top}/${MINIZLIB_SOURCE_DIR}) -G "Ninja Multi-Config" \
94-
-DCMAKE_BUILD_TYPE="Release" \
95+
cmake $(cygpath -m ${top}/${MINIZLIB_SOURCE_DIR}) -G "$AUTOBUILD_WIN_CMAKE_GEN" -A "$AUTOBUILD_WIN_VSPLATFORM" \
96+
-DCMAKE_CONFIGURATION_TYPES="Release" \
9597
-DCMAKE_C_FLAGS:STRING="$plainopts" \
9698
-DCMAKE_CXX_FLAGS:STRING="$opts" \
9799
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT="Embedded" \
@@ -129,7 +131,8 @@ pushd "$MINIZLIB_SOURCE_DIR"
129131
pushd "build_$arch"
130132
CFLAGS="$cc_opts" \
131133
LDFLAGS="$ld_opts" \
132-
cmake ${top}/${MINIZLIB_SOURCE_DIR} -G "Ninja Multi-Config" \
134+
cmake ${top}/${MINIZLIB_SOURCE_DIR} -G "Xcode" \
135+
-DCMAKE_CONFIGURATION_TYPES="Release" \
133136
-DCMAKE_C_FLAGS:STRING="$cc_opts" \
134137
-DCMAKE_CXX_FLAGS:STRING="$opts" \
135138
"${config[@]}" \
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
diff --git a/CMakeLists.txt b/CMakeLists.txt
2+
index c684e3e..3439270 100644
3+
--- a/CMakeLists.txt
4+
+++ b/CMakeLists.txt
5+
@@ -5,7 +5,7 @@
6+
# Copyright (C) 2016 Matthias Schmieder
7+
# schmieder.matthias@gmail.com
8+
9+
-cmake_minimum_required(VERSION 3.13)
10+
+cmake_minimum_required(VERSION 3.13...3.31)
11+
12+
# Library version
13+
set(VERSION "4.0.8")

0 commit comments

Comments
 (0)