Skip to content

Commit eece336

Browse files
author
Vector
committed
Fix uploading windows installer when signing disabled
1 parent 98209b3 commit eece336

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

sign-pkg-windows/action.yaml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,24 @@ runs:
8888
shell: bash
8989
run: cat '.app/secondlife_setup_tmp.nsi'
9090

91-
- name: Sign the installer
92-
if: inputs.vault_uri && inputs.cert_name && inputs.client_id && inputs.client_secret && inputs.tenant_id
91+
- name: Export installer path to env
9392
shell: bash
9493
run: |
94+
# pass installer to next steps
9595
installer="$(ls -t .app/*_Setup.exe | head -n 1)"
96-
# pass installer to next step
9796
echo "installer=$installer" >> "$GITHUB_ENV"
97+
98+
- name: Sign the installer
99+
if: inputs.vault_uri && inputs.cert_name && inputs.client_id && inputs.client_secret && inputs.tenant_id
100+
shell: bash
101+
run: |
98102
python "${{ github.action_path }}/sign.py" \
99103
--vault_uri "${{ inputs.vault_uri }}" \
100104
--cert_name "${{ inputs.cert_name }}" \
101105
--client_id "${{ inputs.client_id }}" \
102106
--client_secret "${{ inputs.client_secret }}" \
103107
--tenant_id "${{ inputs.tenant_id }}" \
104-
"$installer"
108+
"${{ env.installer }}"
105109
106110
- name: Post the installer
107111
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)