Skip to content

Commit 0ee3fb5

Browse files
committed
#23: Directory enumeration errors when music file is on an unmountable network drive
1 parent 20a9af3 commit 0ee3fb5

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

WinampNowPlayingToFile/Business/NowPlayingToFileManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private void fetchExtraMetadata(object sender, KeyNotFoundEventArgs args) {
190190
}
191191
})
192192
.FirstOrDefault(bytes => bytes != null);
193-
} catch (DirectoryNotFoundException) {
193+
} catch (Exception e) when (e is not OutOfMemoryException) { // #23: besides a DirectoryNotFoundException, e can also be an IOException and maybe other classes too
194194
return null;
195195
}
196196
}

WinampNowPlayingToFile/NowPlayingToFilePlugin.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ public override void Initialize() {
3535
}
3636

3737
internal void initManager() {
38-
manager!.error += (_, e) => MessageBox.Show($"{e.Message}\nSong filename: {e.song?.Filename}\nStacktrace: {e.InnerException!.StackTrace}", "Now Playing To File error",
39-
MessageBoxButtons.OK, MessageBoxIcon.Error);
38+
manager!.error += (_, e) => MessageBox.Show(
39+
$"{e.Message}\nSong filename: {e.song?.Filename}\nCause: {e.InnerException!.GetType().Name}: {e.InnerException.Message}\nStacktrace: {e.InnerException.StackTrace}",
40+
"Now Playing To File error", MessageBoxButtons.OK, MessageBoxIcon.Error);
4041
}
4142

4243
public override void Config() {

WinampNowPlayingToFile/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@
3232
// You can specify all the values or you can default the Build and Revision Numbers
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
35-
[assembly: AssemblyVersion("2.2.0.0")]
36-
[assembly: AssemblyFileVersion("2.2.0.0")]
35+
[assembly: AssemblyVersion("2.2.1.0")]
36+
[assembly: AssemblyFileVersion("2.2.1.0")]
3737
[assembly: InternalsVisibleTo("Test")]

0 commit comments

Comments
 (0)