adding more tests to improve coverage of a regex helper

Author: AleksandrRogov

src/helpers/Regex.ts

@@ -137,7 +137,7 @@ export function escapeSearchSpecialCharacters(value: string): string {
     return value.replace(SEARCH_SPECIAL_CHARACTERS_REGEX, "\\$&");
 }
 
-const PREFER_CALLBACK_URL_REGEX = /^odata\.callback;\s*url=["']?(.+)["']?$/;
+const PREFER_CALLBACK_URL_REGEX = /^odata\.callback;\s*url=["']?(.+?)["']?$/;
 export function extractPreferCallbackUrl(value: string): string | null {
     const match = PREFER_CALLBACK_URL_REGEX.exec(value);
     return match ? match[1] : null;

tests/common.spec.ts

@@ -44,6 +44,7 @@ describe("Regex.", () => {
             expect(result3).to.be.null;
         });
     });
+
     describe("extractUuidFromUrl -", function () {
         it("uuid", function () {
             const result = Regex.extractUuidFromUrl(mocks.webApiUrl + "tests(fb15ee32-524d-41be-b6a0-7d0f28055d52)");
@@ -56,6 +57,32 @@ describe("Regex.", () => {
             expect(result2).to.be.null;
         });
     });
+
+    describe("extractPreferCallbackUrl -", function () {
+        it("url", function () {
+            const result = Regex.extractPreferCallbackUrl('odata.callback;url="https://test.com"');
+            expect(result).to.equal("https://test.com");
+        });
+        it("not url - returns null", function () {
+            const result = Regex.extractPreferCallbackUrl("something");
+            expect(result).to.be.null;
+        });
+    });
+
+    describe("getUpdateMethod -", function () {
+        it("PATCH", function () {
+            const result = Regex.getUpdateMethod("anything");
+            expect(result).to.equal("PATCH");
+        });
+        it("PUT", function () {
+            const result = Regex.getUpdateMethod("EntityDefinitions");
+            expect(result).to.equal("PUT");
+        });
+        it("not PUT or PATCH - returns null", function () {
+            const result = Regex.getUpdateMethod(null);
+            expect(result).to.equal("PATCH");
+        });
+    });
 });
 
 describe("RequestClient.sendRequest", () => {