Skip to content

Commit dc5cf45

Browse files
fixing declaration file issue from previous release; continue rewriting js tests to ts
1 parent afc2f75 commit dc5cf45

File tree

3 files changed

+274
-319
lines changed

3 files changed

+274
-319
lines changed

src/dynamics-web-api.ts

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -277,20 +277,12 @@ export class DynamicsWebApi {
277277
internalRequest.url = response?.data.location;
278278
delete internalRequest.transferMode;
279279
delete internalRequest.fieldName;
280+
delete internalRequest.property;
280281
delete internalRequest.fileName;
281282
return this._uploadFileChunk(internalRequest, request.data, response?.data.chunkSize);
282283
};
283284

284-
private _downloadFileChunk = async (
285-
request: InternalRequest,
286-
bytesDownloaded: number = 0,
287-
// fileSize: number = 0,
288-
data: string = ""
289-
): Promise<DownloadResponse> => {
290-
// bytesDownloaded = bytesDownloaded || 0;
291-
// fileSize = fileSize || 0;
292-
// data = data || "";
293-
285+
private _downloadFileChunk = async (request: InternalRequest, bytesDownloaded: number = 0, data: string = ""): Promise<DownloadResponse> => {
294286
request.range = "bytes=" + bytesDownloaded + "-" + (bytesDownloaded + Utility.downloadChunkSize - 1);
295287
request.downloadSize = "full";
296288

@@ -632,7 +624,7 @@ export class DynamicsWebApi {
632624
* @returns {Promise} D365 Web Api Response
633625
*/
634626
callAction: CallAction = async <TResponse = any, TAction = any>(
635-
request: BoundActionRequest<TAction> | UnboundActionRequest<TAction>
627+
request: BoundActionRequest<TAction> | UnboundActionRequest<TAction>,
636628
): Promise<TResponse> => {
637629
ErrorHelper.parameterCheck(request, `DynamicsWebApi.callAction`, "request");
638630
ErrorHelper.stringParameterCheck(request.actionName, `DynamicsWebApi.callAction`, "request.actionName");
@@ -1336,9 +1328,9 @@ export interface DeleteRequest extends CRUDRequest {
13361328
/**BATCH REQUESTS ONLY! Sets Content-ID header or references request in a Change Set. */
13371329
contentId?: string;
13381330
/**
1339-
* Field name that needs to be cleared (for example File Field)
1331+
* Field name that needs to be cleared (for example File Field)
13401332
* @deprecated Use "property".
1341-
*/
1333+
*/
13421334
fieldName?: string;
13431335
/**Single property that needs to be cleared (including the File property) */
13441336
property?: string;
@@ -1442,9 +1434,9 @@ export interface UnboundFunctionRequest extends BaseRequest {
14421434
*/
14431435
name?: string;
14441436
/**
1445-
* Name of the function.
1437+
* Name of the function.
14461438
* @deprecated Use "name" parameter.
1447-
*/
1439+
*/
14481440
functionName?: string;
14491441
/**Function's input parameters. Example: { param1: "test", param2: 3 }. */
14501442
parameters?: any;
@@ -1627,20 +1619,20 @@ export interface UploadRequest extends CRUDRequest {
16271619
/**The name of File Column (field) */
16281620
property?: string;
16291621
/**
1630-
* File Field Name
1622+
* File Field Name
16311623
* @deprecated Use "property".
16321624
*/
1633-
fieldName: string;
1625+
fieldName?: string;
16341626
}
16351627

16361628
export interface DownloadRequest extends CRUDRequest {
16371629
/**The name of File Column (field) */
16381630
property?: string;
16391631
/**
1640-
* File Field Name
1632+
* File Field Name
16411633
* @deprecated Use "property".
16421634
*/
1643-
fieldName: string;
1635+
fieldName?: string;
16441636
}
16451637

16461638
export interface CsdlMetadataRequest extends BaseRequest {

tests/xhr.spec.js

Lines changed: 0 additions & 284 deletions
This file was deleted.

0 commit comments

Comments
 (0)