Skip to content

Commit ebe65d5

Browse files
committed
feat!: upgrade to Minecraft 1.21.0, update dependencies, remove unused dependencies
1 parent 44d2ab3 commit ebe65d5

File tree

9 files changed

+17
-198
lines changed

9 files changed

+17
-198
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Download: https://modrinth.com/plugin/notquests/versions
1010

1111
![Banner](https://user-images.githubusercontent.com/70709113/133943253-af271d49-441b-473e-8b95-6053fe5d09cb.png)
1212

13-
NotQuests is a flexible, Minecraft 1.17-1.20 Quest plugin, featuring a complete GUI for player interactions, open & trusted source code and flexibility.
13+
NotQuests is a flexible, Minecraft 1.17-1.21 Quest plugin, featuring a complete GUI for player interactions, open & trusted source code and flexibility.
1414
---
1515

1616
I created NotQuests for my own server, mc.notnot.pro and planned to keep it private. However, I don't have enough time to maintain it myself, so I just made it public.
@@ -119,7 +119,7 @@ Admin Commands - Quest Editing:
119119

120120

121121
**Requirements to run this:**
122-
- Paper 1.17.1 - 1.20.6
122+
- Paper 1.17.1 - 1.21.1
123123
- Java 17
124124

125125

build.gradle.kts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,26 @@ import org.gradle.api.JavaVersion.*
2121
plugins {
2222
`java-library`
2323
`maven-publish`
24-
id("io.github.goooler.shadow") version "8.1.7"
25-
id("io.papermc.paperweight.userdev") version "1.7.0"
24+
id("com.gradleup.shadow") version "8.3.1"
25+
id("io.papermc.paperweight.userdev") version "1.7.3"
2626
id("xyz.jpenilla.run-paper") version "2.2.4" // Adds runServer and runMojangMappedServer tasks for testing
2727
}
2828

2929
subprojects {
3030
plugins.apply("java-library")
3131
plugins.apply("maven-publish")
32-
plugins.apply("io.github.goooler.shadow")
32+
plugins.apply("com.gradleup.shadow")
3333
}
3434

3535
group = "rocks.gravili.notquests"
36-
version = "5.18.2"
36+
version = "5.19.0"
3737

3838

3939
repositories {
4040
}
4141

4242
dependencies {
43-
paperweight.paperDevBundle("1.20.6-R0.1-SNAPSHOT")
43+
paperweight.paperDevBundle("1.21.1-R0.1-SNAPSHOT")
4444
}
4545

4646
java {
@@ -80,7 +80,7 @@ tasks {
8080
// Configure the Minecraft version for our task.
8181
// This is the only required configuration besides applying the plugin.
8282
// Your plugin's jar (or shadowJar if present) will be used automatically.
83-
minecraftVersion("1.20.6")
83+
minecraftVersion("1.21.1")
8484
}
8585
}
8686

paper/build.gradle.kts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ repositories {
161161

162162
dependencies {
163163
implementation(project(path= ":common", configuration= "shadow"))
164-
paperweight.paperDevBundle("1.20.6-R0.1-SNAPSHOT")
164+
paperweight.paperDevBundle("1.21.1-R0.1-SNAPSHOT")
165165
//compileOnly("io.papermc.paper:paper-api:1.18.1-R0.1-SNAPSHOT!!")
166166
//implementation("de.themoep:inventorygui:1.5-SNAPSHOT")
167167

@@ -249,11 +249,8 @@ dependencies {
249249
implementation("com.github.Redempt:Crunch:2.0.3")
250250

251251

252-
implementation("com.fasterxml.jackson.core:jackson-core:2.17.0")
253-
implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.17.0")
254-
implementation("org.apache.httpcomponents:httpclient:4.5.14")
255252

256-
implementation("com.zaxxer:HikariCP:5.1.0")
253+
implementation("com.zaxxer:HikariCP:6.0.0")
257254

258255
compileOnly("com.github.war-systems:UltimateJobs:0.3.6")
259256

@@ -376,7 +373,7 @@ tasks {
376373
// Configure the Minecraft version for our task.
377374
// This is the only required configuration besides applying the plugin.
378375
// Your plugin's jar (or shadowJar if present) will be used automatically.
379-
minecraftVersion("1.20.6")
376+
minecraftVersion("1.21.1")
380377
}
381378
}
382379

paper/src/main/java/rocks/gravili/notquests/paper/NotQuests.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ public class NotQuests extends NotQuestsMainAbstract<Component, CommandSender> {
8282
private MessageManager messageManager;
8383
private TagManager tagManager;
8484
private ItemsManager itemsManager;
85-
private WebManager webManager;
8685

8786
//Registering Managers
8887
private ObjectiveManager objectiveManager;
@@ -270,7 +269,6 @@ public void onEnable() {
270269

271270
itemsManager = new ItemsManager(this);
272271

273-
webManager = new WebManager(this);
274272

275273
NotQuestsFullyLoadedEvent notQuestsFullyLoadedEvent = new NotQuestsFullyLoadedEvent(this);
276274
if (Bukkit.isPrimaryThread()) {
@@ -534,9 +532,6 @@ public final ItemsManager getItemsManager(){
534532
return itemsManager;
535533
}
536534

537-
public final WebManager getWebManager(){
538-
return webManager;
539-
}
540535

541536
public final MiniMessage getMiniMessage(){
542537
return messageManager.getMiniMessage();

paper/src/main/java/rocks/gravili/notquests/paper/commands/AdminCommands.java

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -695,44 +695,6 @@ public AdminCommands(final NotQuests main, PaperCommandManager<CommandSender> ma
695695
context.getSender().sendMessage(main.parse(
696696
"<main>This feature is still in development. The web editor does not work at all yet. Sorry! This command just acts as a placeholder. Consult the NotQuests documentation for a tutorial on how to use NotQuests."
697697
));
698-
if(true){
699-
return;
700-
}
701-
context.getSender().sendMessage(main.parse(
702-
"<main>Opening the web editor..."
703-
));
704-
705-
String jsonResult = main.getWebManager().openEditor();
706-
707-
/*context.getSender().sendMessage(main.parse(
708-
"<main>Result: " + jsonResult
709-
));*/
710-
711-
String editorURL = "";
712-
713-
try {
714-
JSONParser parser = new JSONParser();
715-
Object resultObject = parser.parse(jsonResult);
716-
717-
if (resultObject instanceof JSONArray array) {
718-
editorURL = "error";
719-
}else if (resultObject instanceof JSONObject obj) {
720-
editorURL = ""+(long)(obj.get("editor_id"));
721-
}
722-
723-
} catch (Exception e) {
724-
e.printStackTrace();
725-
context.getSender().sendMessage(main.parse(
726-
"<error>Failed to parse json!"
727-
));
728-
editorURL = "error";
729-
}
730-
731-
editorURL = "https://editor.notquests.com/editor/" + editorURL;
732-
733-
context.getSender().sendMessage(main.parse(
734-
"<success>Click following link to open the editor: \n<highlight><click:open_url:" + editorURL + "><hover:show_text:\"<highlight>Click to open the web editor\">" + editorURL
735-
));
736698
}));
737699

738700

paper/src/main/java/rocks/gravili/notquests/paper/managers/DataManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,7 @@ public void updateAndReadGeneralConfig() {
12321232

12331233
main.getLogManager().info("Detected version: " + Bukkit.getBukkitVersion() + " <highlight>(Paper)");
12341234

1235-
if (!Bukkit.getBukkitVersion().contains("1.20")) {
1235+
if (!Bukkit.getBukkitVersion().contains("1.21")) {
12361236
if (!configuration.isPacketMagicUnsafeDisregardVersion()) {
12371237
configuration.setPacketMagic(false);
12381238
main.getLogManager().info("Packet magic has been disabled, because you are using an unsupported bukkit version...");

paper/src/main/java/rocks/gravili/notquests/paper/managers/WebManager.java

Lines changed: 0 additions & 135 deletions
This file was deleted.

paper/src/main/java/rocks/gravili/notquests/paper/managers/packets/PacketManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public class PacketManager implements Listener {
5050
public PacketManager(final NotQuests main) {
5151
this.main = main;
5252
usePacketEvents = main.getConfiguration().usePacketEvents;
53-
modern = Bukkit.getVersion().contains("1.20");
53+
modern = Bukkit.getVersion().contains("1.21");
5454
}
5555

5656
public final ReflectionPacketInjector getPacketInjector() {

plugin/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ repositories {
126126
}
127127

128128
dependencies {
129-
paperweight.paperDevBundle("1.20.6-R0.1-SNAPSHOT")
129+
paperweight.paperDevBundle("1.21.1-R0.1-SNAPSHOT")
130130

131131
implementation(project(path= ":common", configuration= "shadow"))
132132
implementation(project(path= ":paper", configuration= "shadow"))
@@ -193,7 +193,7 @@ tasks {
193193
// Configure the Minecraft version for our task.
194194
// This is the only required configuration besides applying the plugin.
195195
// Your plugin's jar (or shadowJar if present) will be used automatically.
196-
minecraftVersion("1.20.6")
196+
minecraftVersion("1.21.1")
197197
}
198198
}
199199

@@ -217,9 +217,9 @@ bukkit {
217217
name = "NotQuests"
218218
version = rootProject.version.toString()
219219
main = "rocks.gravili.notquests.Main"
220-
apiVersion = "1.20"
220+
apiVersion = "1.21"
221221
authors = listOf("AlessioGr")
222-
description = "Flexible, open, GUI Quest Plugin for Minecraft 1.20.6"
222+
description = "Flexible, open, GUI Quest Plugin for Minecraft 1.21.1"
223223
website = "https://www.notquests.com"
224224
softDepend = listOf(
225225
"ProtocolLib",

0 commit comments

Comments
 (0)