fix: simplified test coverage and fix tests checks

Author: caneppelevitor

cypress/e2e/tests/auth/signup.cy.ts

@@ -29,7 +29,11 @@ describe("Sign Up tests", () => {
         cy.get(locators.signup.REPEATED_PASSWORD).type(testUser.password);
         cy.checkRecaptcha();
         cy.get(locators.signup.BTN_SUBMIT).click();
-        cy.contains("Campo obrigatório").should("be.visible");
+        cy.get(locators.signup.ERROR_NAME).should("be.visible");
+        cy.get(locators.signup.ERROR_NAME).should(
+            "contain",
+            "Please, insert your name"
+        );
     });
 
     it("Should show validation error when email is invalid", () => {
@@ -39,7 +43,8 @@ describe("Sign Up tests", () => {
         cy.get(locators.signup.REPEATED_PASSWORD).type(testUser.password);
         cy.checkRecaptcha();
         cy.get(locators.signup.BTN_SUBMIT).click();
-        cy.contains("E-mail inválido").should("be.visible");
+        cy.get(locators.signup.ERROR_EMAIL).should("be.visible");
+        cy.get(locators.signup.ERROR_EMAIL).should("contain", "Invalid e-mail");
     });
 
     it("Should show validation error when passwords don't match", () => {
@@ -49,7 +54,11 @@ describe("Sign Up tests", () => {
         cy.get(locators.signup.REPEATED_PASSWORD).type("DifferentPassword123!");
         cy.checkRecaptcha();
         cy.get(locators.signup.BTN_SUBMIT).click();
-        cy.contains("senhas não são iguais").should("be.visible");
+        cy.get(locators.signup.ERROR_REPEATED_PASSWORD).should("be.visible");
+        cy.get(locators.signup.ERROR_REPEATED_PASSWORD).should(
+            "contain",
+            "The two passwords that you entered do not match"
+        );
     });
 
     it("Should show error when CAPTCHA is not completed", () => {
@@ -58,7 +67,7 @@ describe("Sign Up tests", () => {
         cy.get(locators.signup.PASSWORD).type(testUser.password);
         cy.get(locators.signup.REPEATED_PASSWORD).type(testUser.password);
         cy.get(locators.signup.BTN_SUBMIT).click();
-        cy.contains("Campo obrigatório").should("be.visible");
+        cy.contains("Field is required").should("be.visible");
     });
 
     it("Should successfully create account with valid data and CAPTCHA", () => {
@@ -67,21 +76,19 @@ describe("Sign Up tests", () => {
         cy.get(locators.signup.PASSWORD).type(testUser.password);
         cy.get(locators.signup.REPEATED_PASSWORD).type(testUser.password);
         cy.checkRecaptcha();
-        cy.get(locators.signup.BTN_SUBMIT).click();
 
-        // After successful registration, user should be redirected to home
-        cy.url().should("eq", "http://localhost:3000/");
-        cy.contains("Cadastro realizado com sucesso").should("be.visible");
-    });
+        // Intercept the registration API call
+        cy.intercept("POST", "/api/user/register").as("registerUser");
+        cy.intercept("/api/.ory/sessions/whoami").as("confirmLogin");
 
-    it("Should show error when email already exists", () => {
-        cy.get(locators.signup.NAME).type("Duplicate User");
-        cy.get(locators.signup.EMAIL).type("existing@aletheiafact.org");
-        cy.get(locators.signup.PASSWORD).type(testUser.password);
-        cy.get(locators.signup.REPEATED_PASSWORD).type(testUser.password);
-        cy.checkRecaptcha();
         cy.get(locators.signup.BTN_SUBMIT).click();
 
-        cy.contains(/usuário já existe|já cadastrado/i).should("be.visible");
+        // Wait for registration to complete
+        cy.wait("@registerUser", { timeout: 30000 });
+        cy.wait("@confirmLogin", { timeout: 30000 });
+
+        // After successful registration, user should be redirected to home
+        cy.url({ timeout: 30000 }).should("eq", "http://localhost:3000/");
+        cy.contains("Sign-up successful").should("be.visible");
     });
 });

cypress/support/locators.ts

@@ -13,6 +13,10 @@ const locators = {
         PASSWORD: "[data-cy=passwordInputCreateAccount]",
         REPEATED_PASSWORD: "[data-cy=repeatedPasswordInputCreateAccount]",
         BTN_SUBMIT: "[data-cy=loginButton]",
+        ERROR_NAME: "[data-cy=nameError]",
+        ERROR_EMAIL: "[data-cy=emailError]",
+        ERROR_PASSWORD: "[data-cy=passwordError]",
+        ERROR_REPEATED_PASSWORD: "[data-cy=repeatedPasswordError]",
     },
 
     personality: {

public/locales/en/login.json

@@ -7,6 +7,7 @@
     "nameLabel": "Name",
     "submitButton": "Submit",
     "emailErrorMessage": "Please, insert your e-mail",
+    "invalidEmailErrorMessage": "Invalid e-mail",
     "nameErrorMessage": "Please, insert your name",
     "passwordErrorMessage": "Please, insert your password",
     "loginFailedMessage": "Error while logging in",

src/components/Login/SignUpForm.tsx

@@ -64,6 +64,7 @@ const SignUpForm = ({ onFinish, onFinishFailed, isLoading }) => {
                             })}
                         />
                         <TextError
+                            data-cy="nameError"
                             stateError={errors.name}
                             children={t("login:nameErrorMessage")}
                         />
@@ -84,6 +85,7 @@ const SignUpForm = ({ onFinish, onFinishFailed, isLoading }) => {
                             })}
                         />
                         <TextError
+                            data-cy="emailError"
                             stateError={errors.email}
                             children={
                                 errors.email?.type === "pattern"
@@ -106,6 +108,7 @@ const SignUpForm = ({ onFinish, onFinishFailed, isLoading }) => {
                             })}
                         />
                         <TextError
+                            data-cy="passwordError"
                             stateError={errors.password}
                             children={t("login:passwordErrorMessage")}
                         />
@@ -125,6 +128,7 @@ const SignUpForm = ({ onFinish, onFinishFailed, isLoading }) => {
                             })}
                         />
                         <TextError
+                            data-cy="repeatedPasswordError"
                             stateError={errors.repeatedPassword}
                             children={
                                 errors.repeatedPassword?.type === "required"

src/components/TextErrorForm.tsx

@@ -1,19 +1,20 @@
 import React from "react";
 import colors from "../styles/colors";
 
-const TextError = ({ children, stateError }) => {
-  return (
-    <p
-      style={{
-        fontSize: 14,
-        color: colors.error,
-        visibility: stateError ? "visible" : "hidden",
-        marginBottom: 4,
-      }}
-    >
-      {children}
-    </p>
-  );
+const TextError = ({ children, stateError, "data-cy": dataCy }) => {
+    return (
+        <p
+            data-cy={dataCy}
+            style={{
+                fontSize: 14,
+                color: colors.error,
+                visibility: stateError ? "visible" : "hidden",
+                marginBottom: 4,
+            }}
+        >
+            {children}
+        </p>
+    );
 };
 
 export default TextError;