Fixed composer update during cleanup.

Author: AlexSkrypnyk

CustomizeCommand.php

@@ -227,12 +227,23 @@ protected function process(array $answers): void {
   protected function cleanup(): void {
     $json = $this->readComposerJson();
 
+    $is_dependency = (
+      !empty($json['require'])
+      && is_array($json['require'])
+      && isset($json['require']['alexskrypnyk/customizer'])
+    ) || (
+      !empty($json['require-dev'])
+      && is_array($json['require-dev'])
+      && isset($json['require-dev']['alexskrypnyk/customizer'])
+    );
+
     static::arrayUnsetDeep($json, ['autoload', 'classmap'], basename(__FILE__), FALSE);
     static::arrayUnsetDeep($json, ['scripts', 'customize']);
     static::arrayUnsetDeep($json, ['scripts', 'post-create-project-cmd'], '@customize');
 
     static::arrayUnsetDeep($json, ['require-dev', 'alexskrypnyk/customizer']);
     static::arrayUnsetDeep($json, ['autoload-dev', 'psr-4', 'AlexSkrypnyk\\Customizer\\Tests\\']);
+    static::arrayUnsetDeep($json, ['config', 'allow-plugins', 'alexskrypnyk/customizer']);
 
     if (!empty($this->cleanupCallback)) {
       call_user_func_array($this->cleanupCallback, [&$json, $this]);
@@ -242,17 +253,16 @@ protected function cleanup(): void {
     if (strcmp(serialize($this->packageData), serialize($json)) !== 0) {
       $this->writeComposerJson($json);
 
-      if ($this->isComposerDependenciesInstalled) {
+      // We can only update the composer.lock file if the Customizer was not run
+      // after the Composer dependencies were installed and the Customizer
+      // was not installed as a dependency because the files will be removed
+      // and this process will no longer have required dependencies.
+      // For a Customizer installed as a dependency, the user should run
+      // `composer update` manually (or through a plugin) after the Customizer
+      // is finished.
+      if ($this->isComposerDependenciesInstalled && !$is_dependency) {
         $this->io->writeLn('Updating composer.lock file after customization.');
         static::passthru('composer update --quiet --no-interaction --no-progress');
-        // Composer checks for plugins within installed packages, even if the
-        // packages are no longer is `composer.json`. So we need to remove the
-        // plugin from the `composer.json` and update the dependencies again.
-        if (isset($json['config']['allow-plugins']['alexskrypnyk/customizer'])) {
-          static::arrayUnsetDeep($json, ['config', 'allow-plugins', 'alexskrypnyk/customizer']);
-          $this->writeComposerJson($json);
-          passthru('composer update --quiet --no-interaction --no-progress');
-        }
       }
     }
 

Plugin.php

@@ -73,6 +73,9 @@ public function postRootPackageInstall(PackageEvent $event): void {
       $scripts = $event->getComposer()->getPackage()->getScripts();
       $scripts['customize'][] = CustomizeCommand::class;
       $scripts['post-create-project-cmd'][] = '@customize';
+      // Since we are removing the plugin, we need to run `composer update`,
+      // but in a separate process to avoid a dependency deadlock.
+      $scripts['post-create-project-cmd'][] = '@composer update --quiet --no-interaction --no-progress --no-plugins';
       $package->setScripts($scripts);
     }
   }

tests/phpunit/Fixtures/plugin/.customizer.php

@@ -181,7 +181,7 @@ public static function processLicense(string $title, string $answer, array $answ
    * A callback to process cleanup.
    */
   public static function cleanup(array &$composerjson, CustomizeCommand $customizer): void {
-    unset($composerjson['config']['sort-packages']);
+    $customizer::arrayUnsetDeep($composerjson, ['config', 'sort-packages']);
   }
 
 }

tests/phpunit/Traits/ComposerTrait.php

@@ -33,7 +33,10 @@ protected function composerCommandInit(): void {
   protected function assertComposerCommandSuccessOutputContains(string|array $strings): void {
     $strings = is_array($strings) ? $strings : [$strings];
 
-    $this->assertSame(0, $this->tester->getStatusCode());
+    if ($this->tester->getStatusCode() !== 0) {
+      $this->fail($this->tester->getDisplay());
+    }
+    $this->assertSame(0, $this->tester->getStatusCode(), sprintf("The Composer command should have completed successfully:\n%s", $this->tester->getInput()->__toString()));
 
     $output = $this->tester->getDisplay(TRUE);
     foreach ($strings as $string) {