[File-Management] Take into account that read file names might be empty.

Author: Alexander-Miller

src/elisp/treemacs-bookmarks.el

@@ -196,16 +196,19 @@ treemacs node is pointing to a valid buffer position."
    (pcase (treemacs-button-get current-btn :state)
      ((or 'file-node-open 'file-node-closed 'dir-node-open 'dir-node-closed)
       (-let [name (treemacs--read-string "Bookmark name: ")]
-        (bookmark-store name `((filename . ,(treemacs-button-get current-btn :path))) nil)))
+        (when name
+          (bookmark-store name `((filename . ,(treemacs-button-get current-btn :path))) nil))))
      ('tag-node
       (-let [(tag-buffer . tag-pos)
              (treemacs--extract-position (treemacs-button-get current-btn :marker) nil)]
         (if (buffer-live-p tag-buffer)
-            (bookmark-store
-             (treemacs--read-string "Bookmark name: ")
-             `((filename . ,(buffer-file-name tag-buffer))
-               (position . ,tag-pos))
-             nil)
+            (-let [name (treemacs--read-string "Bookmark name: ")]
+              (when name
+                (bookmark-store
+                 name
+                 `((filename . ,(buffer-file-name tag-buffer))
+                   (position . ,tag-pos))
+                 nil)))
           (treemacs-log-failure "Tag info can not be saved because it is not pointing to a live buffer."))))
      ((or 'tag-node-open 'tag-node-closed)
       (treemacs-pulse-on-failure "There is nothing to bookmark here.")))))

src/elisp/treemacs-file-management.el

@@ -360,8 +360,10 @@ will likewise be updated."
        (treemacs-error-return-if (not (file-exists-p old-path))
          "The file to be renamed does not exist.")
        (let* ((old-name  (treemacs--filename old-path))
-              (new-name  (treemacs--read-string
-                          "New name: " (file-name-nondirectory old-path)))
+              (new-name  (--if-let (treemacs--read-string
+                                    "New name: " (file-name-nondirectory old-path))
+                             it
+                           (treemacs-return nil)))
               (dir       (treemacs--parent-dir old-path))
               (new-path  (treemacs-join-path dir new-name))
               (parent    (treemacs-button-get btn :parent)))

src/elisp/treemacs-workspaces.el

@@ -176,7 +176,6 @@ PATH: String"
                ('always-ask
                 (treemacs--select-workspace-by-name))))))))
 
-;; TODO(2020/11/25): NAME
 (define-inline treemacs--find-project-for-buffer (&optional buffer-file)
   "In the current workspace find the project current buffer's file falls under.
 Optionally supply the BUFFER-FILE in case it is not available by calling the
@@ -703,7 +702,8 @@ Returns t when the name is invalid.
 
 NAME: String"
   (declare (pure t) (side-effect-free t))
-  (or (s-blank-str? name)
+  (or (null name)
+      (s-blank-str? name)
       (s-contains? "\n" name)
       (not (s-matches? (rx (1+ (or space (syntax word) (syntax symbol) (syntax punctuation)))) name))))