Написал тесты на Command.java и FileUtils.java

пофиксил баги

Author: AlexanderBazarov

src/main/java/ru/untitled_devs/core/middlewares/LoggingMiddleware.java

@@ -2,8 +2,6 @@
 
 import org.telegram.telegrambots.meta.api.objects.Update;
 
-import java.util.Objects;
-
 public class Command implements Filter{
     String command;
 
@@ -14,7 +12,7 @@ public Command(String command) {
     @Override
     public boolean check(Update update) {
         if (!update.hasMessage() || update.getMessage().getText() == null ||
-                update.getMessage().getText().startsWith("/")) {
+                !update.getMessage().getText().startsWith("/")) {
             return false;
         }
 

src/main/java/ru/untitled_devs/core/routers/filters/Command.java

@@ -1,7 +1,6 @@
 package ru.untitled_devs.core.routers.filters;
 
-public class CommandStart extends Command{
-
+public class CommandStart extends Command {
     public CommandStart() {
         super("start");
     }

src/main/java/ru/untitled_devs/core/routers/filters/CommandStart.java

@@ -19,7 +19,7 @@ public static String getImageFileNameWithExtension(byte[] data) {
             case "image/jpeg" -> ".jpg";
             case "image/gif" -> ".gif";
             case "image/webp" -> ".webp";
-            default -> ".bin";
+            default -> "";
         };
 
         return UUID.randomUUID() + ext;

src/main/java/ru/untitled_devs/core/utils/FileUtils.java

@@ -0,0 +1,68 @@
+package ru.untitleddevs.core.routers.filters;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.telegram.telegrambots.meta.api.objects.Message;
+import org.telegram.telegrambots.meta.api.objects.Update;
+import ru.untitled_devs.core.routers.filters.Command;
+import static org.junit.jupiter.api.Assertions.*;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class CommandTest {
+
+    private Update updateMock;
+    private Message messageMock;
+
+    @BeforeEach
+    void setUp() {
+        updateMock = mock(Update.class);
+        messageMock = mock(Message.class);
+        when(updateMock.getMessage()).thenReturn(messageMock);
+        when(updateMock.hasMessage()).thenReturn(true);
+    }
+
+    @Test
+    void checkReturnsTrueWhenCommandMatches() {
+        Command command = new Command("test");
+        when(messageMock.getText()).thenReturn("/test");
+        when(updateMock.hasMessage()).thenReturn(true);
+
+        boolean result = command.check(updateMock);
+        assertTrue(result, "check() should return true when the text contains the command");
+
+    }
+
+    @Test
+    void checkReturnsTrueWhenMultiwordCommandMatched() {
+        Command command = new Command("test");
+        when(messageMock.getText()).thenReturn("/test arg1 arg2");
+        when(updateMock.hasMessage()).thenReturn(true);
+
+        boolean result = command.check(updateMock);
+        assertTrue(result, "check() should return true when the text contains the command");
+    }
+
+    @Test
+    void checkReturnsTrueWhenCommandNotMatches() {
+        Command command = new Command("start");
+        when(messageMock.getText()).thenReturn("/test");
+        when(updateMock.hasMessage()).thenReturn(true);
+
+        boolean result = command.check(updateMock);
+        assertFalse(result, "check() should return false when the text not contains the command");
+
+    }
+
+    @Test
+    void checkReturnsTrueWhenMultiwordCommandNotMatched() {
+        Command command = new Command("start");
+        when(messageMock.getText()).thenReturn("/test arg1 arg2");
+        when(updateMock.hasMessage()).thenReturn(true);
+
+        boolean result = command.check(updateMock);
+        assertFalse(result, "check() should return false when the text not contains the command");
+    }
+
+}

src/test/java/ru/untitleddevs/core/routers/filters/CommandTest.java

@@ -0,0 +1,57 @@
+package ru.untitleddevs.core.utils;
+
+import org.junit.jupiter.api.Test;
+import ru.untitled_devs.core.utils.FileUtils;
+import static org.junit.jupiter.api.Assertions.*;
+
+import java.util.Base64;
+
+public class FileUtilsTest {
+    @Test
+    void getImageFileNameWithExtensionGotValidPng() {
+        byte[] data = Base64.getDecoder().decode(
+                "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVQI12NgYAAAAAMAASsJ"
+        );
+        String filename = FileUtils.getImageFileNameWithExtension(data);
+        assertTrue(filename.endsWith(".png"));
+    }
+
+    @Test
+    void getImageFileNameWithExtensionGotValidJpeg() {
+        byte[] data = Base64.getDecoder().decode(
+                "/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAP//////////////////////////////////////////////////////////////////////////////////////" +
+                        "2wBDAf//////////////////////////////////////////////////////////////////////////////////////" +
+                        "wAARCAABAAEDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAb/xAAUEQEAAAAAAAAAAAAAAAAAAAAA/8QAFQEBAQAAAAAAAAAAAAAAAAAAAgP/" +
+                        "xAAUEQEAAAAAAAAAAAAAAAAAAAAA/9oADAMBAAIRAxEAPwD9AP/Z"
+        );
+        String filename = FileUtils.getImageFileNameWithExtension(data);
+        assertTrue(filename.endsWith(".jpg"));
+    }
+
+    @Test
+    void getImageFileNameWithExtensionGotValidGif() {
+        byte[] data = Base64.getDecoder().decode(
+                "R0lGODdhAQABAIAAAAAAAP///ywAAAAAAQABAAACAkQBADs="
+        );
+        String filename = FileUtils.getImageFileNameWithExtension(data);
+        assertTrue(filename.endsWith(".gif"));
+    }
+
+    @Test
+    void getImageFileNameWithExtensionGotValidWebp() {
+        byte[] data = Base64.getDecoder().decode(
+                "UklGRhIAAABXRUJQVlA4TAYAAAAvAAAAHAAAQQUAAA=="
+        );
+        String filename = FileUtils.getImageFileNameWithExtension(data);
+        assertTrue(filename.endsWith(".webp"));
+    }
+
+    @Test
+    void getImageFileNameWithExtensionGotInvalidData() {
+        byte[] data = Base64.getDecoder().decode("SGVsbG8gd29ybGQ=");
+
+        assertThrows(IllegalArgumentException.class,
+                () -> FileUtils.getImageFileNameWithExtension(data));
+    }
+
+}