fix warnings

(from no IDE in particular)

Author: Govorunb

Immersion/Trackers/Backseating.cs

@@ -95,15 +95,15 @@ private void UpdateBaseGameAlerts()
         CoroutineHost.StartCoroutine(ToggleHypothermiaAlerts(!enabled));
     }
 
-    private void ToggleSurvivalAlerts(bool enabled)
+    private void ToggleSurvivalAlerts(bool enable)
     {
-        SurvivalAlertPatches.EnableSurvivalAlerts = enabled;
+        SurvivalAlertPatches.EnableSurvivalAlerts = enable;
     }
-    private IEnumerator ToggleHypothermiaAlerts(bool enabled)
+    private IEnumerator ToggleHypothermiaAlerts(bool enable)
     {
         yield return new WaitUntil(() => bodyTemp);
         PDANotification notif = bodyTemp.hypothermiaWarningNotification;
-        notif.nextPlayTime = enabled ? 0 : float.PositiveInfinity;
+        notif.nextPlayTime = enable ? 0 : float.PositiveInfinity;
     }
 
     public void FixedUpdate()

Immersion/Trackers/JukeboxTrackUnlocked.cs

@@ -5,17 +5,17 @@ namespace Immersion.Trackers;
 [HarmonyPatch]
 public sealed class JukeboxTrackUnlocked : Tracker
 {
-    internal static HashSet<string> _allowlist = new(StringComparer.InvariantCultureIgnoreCase)
+    internal static readonly HashSet<string> _allowlist = new(StringComparer.InvariantCultureIgnoreCase)
     {
         "truckersfm"
     };
 
     internal void NotifyUnlocked(Jukebox.UnlockableTrack track)
     {
-        if (!Jukebox.unlockableMusic.TryGetValue(track, out string name)) return;
-        if (!_allowlist.Contains(name)) return;
+        if (!Jukebox.unlockableMusic.TryGetValue(track, out string trackId)) return;
+        if (!_allowlist.Contains(trackId)) return;
 
-        React(Priority.Low, Format.FormatPlayer($"{{player}} has unlocked a new jukebox track: {Jukebox.GetInfo(name).label}"));
+        React(Priority.Low, Format.FormatPlayer($"{{player}} has unlocked a new jukebox track: {Jukebox.GetInfo(trackId).label}"));
     }
 
     [HarmonyPatch(typeof(Jukebox), nameof(Jukebox.OnUnlock))]

Immersion/Trackers/NewScans.cs

@@ -16,8 +16,8 @@ public void OnScanned(PDAScanner.Entry entry)
 
     internal void NotifyScanned(TechType techType)
     {
-        string name = Language.main.TryGet(techType, out string nameMaybe) ? nameMaybe : Format.ToTitleCase(techType);
-        string message = Format.FormatPlayer($"{{player}} has discovered a new creature: {name}.");
+        string techName = Language.main.TryGet(techType, out string nameMaybe) ? nameMaybe : Format.ToTitleCase(techType);
+        string message = Format.FormatPlayer($"{{player}} has discovered a new creature: {techName}.");
 
         string encyKey = PDAScanner.GetEntryData(techType).encyclopedia;
         if (!PDAEncyclopedia.GetEntryData(encyKey, out PDAEncyclopedia.EntryData data)) return;

Immersion/Trackers/StoryGoals.Descriptions.cs

@@ -4,12 +4,12 @@ namespace Immersion.Trackers;
 
 partial class StoryGoals
 {
-    private record class Description(string Message, bool IsImportant = false)
+    private record Description(string Message, bool IsImportant = false)
     {
         public Priority Priority => IsImportant ? Priority.High : Priority.Low;
         public static implicit operator Description(string Message) => new(Message);
     }
-    private static Dictionary<string, Description> StoryGoalDescriptions = new(StoryGoal.KeyComparer)
+    private static readonly Dictionary<string, Description> StoryGoalDescriptions = new(StoryGoal.KeyComparer)
     {
         // sorted roughly in story order
 

Immersion/Trackers/Tracker.cs

@@ -19,7 +19,7 @@ protected internal enum Priority
     public static bool ForceLowPriority
     {
         get => PlayerPrefsExtra.GetBool(forceLowPrioPrefsKey, false);
-        set => PlayerPrefsExtra.SetBool(forceLowPrioPrefsKey, false);
+        set => PlayerPrefsExtra.SetBool(forceLowPrioPrefsKey, value);
     }
     private string startEnabledPrefsKey => $"{GetType().FullName}_Enabled";
     internal bool startEnabled

SCHIZO/Commands/Attributes/CommandAttribute.cs

@@ -1,8 +1,10 @@
 using System;
+using JetBrains.Annotations;
 
 namespace SCHIZO.Commands.Attributes;
 
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)]
+[MeansImplicitUse]
 public class CommandAttribute : Attribute
 {
     public required string Name { get; set; }

SCHIZO/Commands/Base/MethodCommand.cs

@@ -14,15 +14,15 @@ internal class MethodCommand : Command, IParameters
     private readonly MethodInfo _method;
     private readonly object? _instance;
     private readonly bool _lastTakeAll;
-    public IReadOnlyList<Parameter> Parameters { get; protected set; } = [];
+    public IReadOnlyList<Parameter> Parameters { get; protected set; }
 
     public MethodCommand(MethodInfo method, object? instance = null)
     {
         if (method.IsStatic && instance is { })
             throw new ArgumentException("Static method does not need instance");
-        else if (!method.IsStatic && instance is null)
+        if (!method.IsStatic && instance is null)
             throw new ArgumentException("Non-static method needs instance");
-        else if (method.Name.IndexOf('>') >= 0) // mangled (delegate, lambda, inner function, etc...)
+        if (method.Name.IndexOf('>') >= 0) // mangled (delegate, lambda, inner function, etc...)
             throw new ArgumentException($"Use {nameof(DelegateCommand)} instead of {nameof(MethodCommand)} for delegate methods (lambda, inner function, etc.)");
         _method = method;
         _instance = instance;
@@ -105,7 +105,7 @@ internal static ArgParseResult TryParseNamedArgs(Dictionary<string, object?>? ar
         return new(consumed == args.Count, parsed == parameters.Count, parsedArgs);
     }
 
-    internal static ArgParseResult TryParsePositionalArgs(IReadOnlyList<string> args, IReadOnlyList<Parameter> parameters, bool lastTakeAll = false)
+    internal static ArgParseResult TryParsePositionalArgs(IReadOnlyList<string>? args, IReadOnlyList<Parameter> parameters, bool lastTakeAll = false)
     {
         if (args is null)
             return new(true, parameters.All(p => p.IsOptional), []);

SCHIZO/Commands/Base/NautilusCommandWrapper.cs

@@ -34,6 +34,7 @@ public static NautilusCommandWrapper Register(Command command)
         }
         NautilusCommandWrapper wrapper = new(command);
         wrapper.RegisterWithNautilus();
+        _registered[command.Name] = wrapper;
         return wrapper;
     }
 

SCHIZO/Commands/DevCommands.cs

@@ -99,7 +99,7 @@ public static object PrintField(string typeName, string memberName)
         Type type = ReflectionCache.GetType(typeName);
         if (type is null) return $"Could not find type '{typeName}'";
         MemberInfo[] member = type.GetMember(memberName, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static);
-        if (member is null) return $"Could not find '{memberName}' in type '{typeName}' (must be static)";
+        if (member.Length == 0) return $"Could not find '{memberName}' in type '{typeName}' (must be static)";
         return ReflectionHelpers.GetStaticMemberValue<object>(member.Single());
     }
 
@@ -111,7 +111,7 @@ public static object SetField(string typeName, string memberName, string valueSt
     {
         Type type = ReflectionCache.GetType(typeName);
         if (type is null) return $"Could not find type '{typeName}'";
-        MemberInfo member = type.GetMember(memberName, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static).Single();
+        MemberInfo member = type.GetMember(memberName, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static).SingleOrDefault();
         if (member is null) return $"Could not find '{memberName}' in type '{typeName}' (must be static)";
         Type memberType = member switch
         {

SCHIZO/Commands/Input/Conversion.cs

@@ -18,7 +18,7 @@ public static bool TryParseOrConvert<T>(object? val, [MaybeNullWhen(false)] out
         return false;
     }
 
-    public static bool TryParseOrConvert(object? val, Type type, [MaybeNullWhen(false)] out object? value)
+    public static bool TryParseOrConvert(object? val, Type type, out object? value)
     {
         value = default;
         if (type.IsEnum)
@@ -27,7 +27,7 @@ public static bool TryParseOrConvert(object? val, Type type, [MaybeNullWhen(fals
         }
         if (val is null)
             return false;
-        if (type.IsAssignableFrom(val.GetType()))
+        if (type.IsInstanceOfType(val))
         {
             value = val;
             return true;
@@ -64,7 +64,7 @@ public static bool TryParseEnum<TEnum>(object? val, [MaybeNullWhen(false)] out T
         return false;
     }
 
-    public static bool TryParseEnum(object? val, Type type, [MaybeNullWhen(false)] out object? value)
+    public static bool TryParseEnum(object? val, Type type, out object? value)
     {
         value = default;
         if (val is null)