Skip to content

Commit 2edea42

Browse files
committed
Add some debugging logs
1 parent 33c9e3b commit 2edea42

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

custom_components/sat/pid.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,11 @@ def _update_integral(self, state: TemperatureState) -> None:
190190
self._integral += self.ki * state.error * PID_UPDATE_INTERVAL
191191
self._integral = clamp_to_range(self._integral, self._heating_curve.value)
192192

193+
_LOGGER.debug(
194+
"PID integral update: entity=%s current_temperature=%.3f target_temperature=%.3 error=%.3f value=%.6f",
195+
self._entity_id, state.current, state.setpoint, state.error, self._integral
196+
)
197+
193198
def _update_derivative(self, state: TemperatureState) -> None:
194199
"""Update the derivative term of the PID controller based on temperature slope."""
195200
if self._last_temperature is None or self._last_derivative_updated is None:
@@ -224,8 +229,8 @@ def _update_derivative(self, state: TemperatureState) -> None:
224229
self._last_derivative_updated = state.last_changed.timestamp()
225230

226231
_LOGGER.debug(
227-
"PID derivative update: entity=%s previous_temperature=%.3f current_temperature=%.3f raw_derivative=%.6f delta_time=%.3f",
228-
self._entity_id, self._last_temperature, state.current, self._raw_derivative, delta_time,
232+
"PID derivative update: entity=%s previous_temperature=%.3f current_temperature=%.3f delta_time=%.3f raw_value=%.6f",
233+
self._entity_id, self._last_temperature, state.current, delta_time, self._raw_derivative,
229234
)
230235

231236
async def _async_save_state(self) -> None:

custom_components/sat/temperature/state.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,5 @@ class TemperatureState:
4646

4747
@property
4848
def error(self) -> float:
49-
"""Return the temperature error (setpoint - current)."""
50-
return round(self.setpoint - self.current, 2)
49+
"""Return the temperature error."""
50+
return self.setpoint - self.current

0 commit comments

Comments
 (0)