Added log4j-slf4j-imp for log4j2. Updated the logging with log4j

Author: AlfredStenwin

.gitignore

@@ -4,4 +4,5 @@
 .classpath
 /.settings/
 /test-output/
-Readme.txt
+Readme.txt
+trial.txt

logs/.gitignore

@@ -0,0 +1,4 @@
+# Ignore everything in this directory
+*
+# Except this file
+!.gitignore

pom.xml

@@ -31,7 +31,7 @@
 		    <scope>compile</scope> <!-- changed from 'tests' to 'compile' to access the testng out of src/test folders and access anywhere -->
 		</dependency>
 
-		<!-- Log4j dependencies-->
+		<!-- Log4j2 dependencies-->
 		<dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-core</artifactId>
@@ -43,6 +43,11 @@
             <artifactId>log4j-api</artifactId>
             <version>2.13.3</version>
         </dependency>
+		<dependency> 
+		    <groupId>org.apache.logging.log4j</groupId> 
+		    <artifactId>log4j-slf4j-impl</artifactId> 
+		    <version>2.13.3</version> 
+		</dependency>
 
 		<!-- Extentreport dependency-->
 		<!-- https://mvnrepository.com/artifact/com.aventstack/extentreports -->

src/main/java/decorators/DriverLogger.java

@@ -2,14 +2,12 @@
 
 import org.openqa.selenium.By;
 
-import logsetup.LogUtility;
+import logsetup.Log;
 
 import java.io.File;
 import java.util.List;
 
 public class DriverLogger extends DriverDecorator {
-	//public static Logger log = LogManager.getLogger(DriverLogger.class);
-	private LogUtility log = LogUtility.getInstance();
 
 	public DriverLogger(Driver driver ) {
         super(driver);
@@ -18,25 +16,25 @@ public DriverLogger(Driver driver ) {
     @Override
     public void start(String browser) {
         driver.start(browser);
-        log.info(String.format("Started browser: %s", browser));
+        Log.info(String.format("Started browser: %s", browser));
     }
 
     @Override
     public void quit() {
         driver.quit();
-    	log.info("Closed browser");
+        Log.info("Closed browser");
     }
 
     @Override
     public void goToUrl(String url) {
         driver.goToUrl(url);
-    	log.info(String.format("Navigated to url: %s", url));
+        Log.info(String.format("Navigated to url: %s", url));
     }
 
     @Override
     public Element findElement(By locator) {
     	var element = driver.findElement(locator);
-    	log.info("Located element by locator "+locator);
+    	Log.info("Located element by locator "+locator);
 
         return element;
     }
@@ -48,7 +46,7 @@ public List<Element> findElements(By locator) {
 
     @Override
     public File takescreenshot() {
-    	log.info("Screenshot taken.");
+    	Log.info("Screenshot taken.");
 		return driver.takescreenshot();		
 	}
 }

src/main/java/decorators/ElementLogger.java

@@ -2,11 +2,9 @@
 
 import org.openqa.selenium.By;
 
-import logsetup.LogUtility;
+import logsetup.Log;
 
 public class ElementLogger extends ElementDecorator {
-	//public static Logger log = LogManager.getLogger("LOG");
-	private LogUtility log = LogUtility.getInstance();
 
 
 	protected ElementLogger(Element element) {
@@ -21,37 +19,37 @@ public By getBy() {
     @Override
     public String getText() {
     	String elementName = element.getText();
-    	log.info(String.format("Element Text = %s", elementName));
+    	Log.info(String.format("Element Text = %s", elementName));
         return elementName;
     }
 
     @Override
     public Boolean isEnabled() {
-        log.info(String.format("Element Enabled = %b", element.isEnabled()));
+    	Log.info(String.format("Element Enabled = %b", element.isEnabled()));
         return element.isEnabled();
     }
 
     @Override
     public Boolean isDisplayed() {
-    	log.info((String.format("Element Displayed = %b", element.isDisplayed())));
+    	Log.info((String.format("Element Displayed = %b", element.isDisplayed())));
         return element.isDisplayed();
     }
 
     @Override
     public void typeText(String text){
-    	log.info((String.format("Type Text = %s", text)));
+    	Log.info((String.format("Type Text = %s", text)));
         element.typeText(text);
     }
 
     @Override
     public void click() {
         element.click();
-    	log.info("Element  Clicked");
+        Log.info("Element  Clicked");
     }
 
     @Override
     public String getAttribute(String attributeName) {
-    	log.info("Trying to get attribute");
+    	Log.info("Trying to get attribute");
         return element.getAttribute(attributeName);
     }
 }

src/main/java/filereaderfactory/JsonFileReader.java

@@ -3,16 +3,22 @@
 import java.io.File;
 import java.io.IOException;
 import java.util.HashMap;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
-import logsetup.LogUtility;
+//import logsetup.LogUtility;
 
 /*Simple json reader - Will fail if used for nested json*/
 
 public class JsonFileReader implements ReaderManager{
 	HashMap<String, Object> map;
 	Object[] dataObject;
+	private static Logger LogUtility = LogManager.getLogger(JsonFileReader.class);
+
 
 
 	public ReaderManager readFile(String filePath) {
@@ -24,7 +30,7 @@ public ReaderManager readFile(String filePath) {
 
 		} catch (IOException e) {
 
-			LogUtility.getInstance().error("Reading from json file failed.");
+			LogUtility.error("Reading from json file failed.");
 			e.printStackTrace();
 		}
 
@@ -40,7 +46,6 @@ public Object[] getObject() {
 
 	@Override
 	public String get(String key) {
-		// TODO Auto-generated method stub
 		return null;
 	}
 }

src/main/java/filereaderfactory/PropertyFileReader.java

@@ -3,10 +3,14 @@
 import java.io.FileReader;
 import java.util.Properties;
 
-import logsetup.LogUtility;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+//import logsetup.LogUtility;
 
 public class PropertyFileReader implements ReaderManager{
 	Properties props;
+	private static Logger LogUtility = LogManager.getLogger(PropertyFileReader.class);
 
 	public ReaderManager readFile(String filePath)
 	{	  
@@ -16,7 +20,7 @@ public ReaderManager readFile(String filePath)
 			props.load(reader);
 
 		} catch (Exception e) {	
-			LogUtility.getInstance().error("Property file couldn't be read.", e);
+			LogUtility.error("Property file couldn't be read.", e);
 		}
 		return this;
 

src/main/java/listeners/TestngListener.java

@@ -3,8 +3,6 @@
 import java.io.File;
 import java.io.IOException;
 
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 import org.openqa.selenium.io.FileHandler;
 import org.testng.ISuite;
 import org.testng.ISuiteListener;
@@ -17,28 +15,24 @@
 import com.aventstack.extentreports.Status;
 
 import decorators.Driver;
-import logsetup.LogUtility;
+import logsetup.Log;
 
 public class TestngListener implements ITestListener, ISuiteListener{
 	ExtentReports extentReport;
 	ExtentTest extentTest ;
-	
-	//protected LogUtility log = LogUtility.getInstance();
-	private static Logger log = LogManager.getLogger("LOG");
-
 
 	@Override
 	public void onStart(ISuite suite) {
 		//To generate extend report at the start of the suite execution
 		extentReport=ExtentReportGenerator.generateReport();	
-		LogUtility.info("\""+suite.getName()+ "\" test suite execution started.");
+		Log.info("\""+suite.getName()+ "\" test suite execution started.");
 	}
 
 	@Override
 	public void onFinish(ISuite suite) {
 		//Flush is used to create the extend report
 		extentReport.flush();		
-		LogUtility.info("\""+suite.getName()+ "\" test suite execution ended.");				
+		Log.info("\""+suite.getName()+ "\" test suite execution ended.");				
 	}
 
 	@Override
@@ -51,15 +45,15 @@ public void onTestStart(ITestResult result) {
 		String testName=result.getName();
 		extentTest = extentReport.createTest(testName);
 		extentTest.log(Status.INFO, testName+" started." );
-		log.info("\""+testName+"\" execution started. EntentTest created");
+		Log.info("\""+testName+"\" execution started. EntentTest created");
 
 	}
 
 	@Override
 	public void onTestSuccess(ITestResult result) {
 		String testName=result.getName();
 		extentTest.log(Status.PASS, testName+" test passed." );
-		log.info("\""+testName+"\" passed.");		
+		Log.info("\""+testName+"\" passed.");		
 
 	}
 
@@ -84,16 +78,15 @@ public void onTestFailure(ITestResult result) {
 			e.printStackTrace();
 		}
 
-		var thrower= result.getThrowable();
 		extentTest.log(Status.FAIL, testName +" failed. \n"+result.getThrowable());
-		log.error("\""+result.getName()+"\" failed.", result.getThrowable());
+		Log.error("\""+result.getName()+"\" failed.", result.getThrowable());
 	}
 
 	@Override
 	public void onTestSkipped(ITestResult result) {
 		String testName=result.getName();
 		extentTest.log(Status.SKIP, testName +" skipped." + result.getThrowable());		
-		log.error("\""+result.getName()+"\" skipped.", result.getThrowable());		
+		Log.error("\""+result.getName()+"\" skipped.", result.getThrowable());		
 	}
 
 	@Override
@@ -103,7 +96,7 @@ public void onFinish(ITestContext context) {
 
 	@Override
 	public void onTestFailedButWithinSuccessPercentage(ITestResult result) {
-		log.info("onTestFailedButWithinSuccessPercentage");		
+		Log.info("onTestFailedButWithinSuccessPercentage");		
 
 	}
 

src/main/java/logsetup/LogUtility.java

@@ -1,11 +1,9 @@
 package webpages;
 
 import decorators.Driver;
-import logsetup.LogUtility;
 
 public abstract class BasePage{
 
-	protected LogUtility log = LogUtility.getInstance();
 	protected final Driver driver;
 
 	public BasePage(Driver driver) {