Removing the factory design pattern used for reading CSV, Proprety and

json files.

Author: AlfredStenwin

pom.xml

@@ -70,7 +70,12 @@
 		    <artifactId>jackson-core</artifactId>
 		    <version>2.14.1</version>
 		</dependency>
-
+		<!-- https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-csv -->
+		<dependency>
+		    <groupId>com.fasterxml.jackson.dataformat</groupId>
+		    <artifactId>jackson-dataformat-csv</artifactId>
+		    <version>2.14.1</version>
+		</dependency>
 
 	 </dependencies>
 

sample.txt

@@ -3,9 +3,7 @@
 import org.openqa.selenium.By;
 
 public class ElementDecorator implements Element {
-    protected final Element element;//composition - by containing
-    //instances of other classes that implement the desired functionality. 
-    //Element class in this case
+    protected final Element element;
 
     protected ElementDecorator(Element element) {
         this.element = element;

src/main/java/decorators/ElementDecorator.java

@@ -2,5 +2,6 @@
 
 public enum FileType {
 	PROPERTY,
-	JSON
+	JSON,
+	CSV
 }

src/main/java/enums/FileType.java

@@ -6,8 +6,7 @@
 import com.aventstack.extentreports.reporter.ExtentSparkReporter;
 import com.aventstack.extentreports.reporter.configuration.Theme;
 
-import enums.FileType;
-import filereaderfactory.FileReaders;
+import utilities.filereaders.PropertyFileReader;
 
 public class ExtentReportGenerator {
 
@@ -16,6 +15,8 @@ public class ExtentReportGenerator {
 	 */
 	public static ExtentReports generateReport() {
 
+		String propertyFilePath = System.getProperty("user.dir")+"/src/test/resources/Config.properties";
+		
 		ExtentReports extentReport = new ExtentReports();
 		File extentReportFile=new File(System.getProperty("user.dir")+"/ExtentReports/ExtentReports.html");
 		ExtentSparkReporter extentSparkReporter=new ExtentSparkReporter(extentReportFile);
@@ -31,9 +32,7 @@ public static ExtentReports generateReport() {
 
 		// setting test and system info from test/resources/Config.properties file
 		extentReport.setSystemInfo("Application URL", 
-				FileReaders.getFileReader(FileType.PROPERTY)
-				.readFile(System.getProperty("user.dir")+"/src/test/resources/Config.properties")
-				.get("url"));
+				PropertyFileReader.readFile(propertyFilePath).get("url").toString());
 		extentReport.setSystemInfo("Operating System",System.getProperty("os.name"));
 		extentReport.setSystemInfo("User name ",System.getProperty("user.name"));
 		extentReport.setSystemInfo("Java version",System.getProperty("java.version"));

src/main/java/filereaderfactory/FileReaders.java

@@ -0,0 +1,21 @@
+package logsetup;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Log{
+
+	public static Logger log = LogManager.getLogger(Log.class.getName());
+	
+    public static void info(String logMessage) {
+        log.info(logMessage);
+    }
+
+    public static void error(String msg, Throwable throwable) {               
+        log.error(msg, throwable);      
+    }
+    
+    public static void error(String msg) {               
+        log.error(msg);      
+    }
+}