Add support for phpBB v4

Author: AlfredoRamos

.github/workflows/ci.yml

@@ -11,19 +11,19 @@ env:
   IMAGE_ICC: 1
   EPV: 1
   EXECUTABLE_FILES: 1
-  PHPBB_BRANCH: 3.3.x
+  PHPBB_BRANCH: master
 
 jobs:
   basic-tests:
     if: ${{ !contains(github.event.head_commit.message, 'skip ci') }}
     name: php ${{ matrix.php-version }}, none none
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     env:
       PHP_VERSION: ${{ matrix.php-version }}
     strategy:
       fail-fast: false
       matrix:
-        php-version: ['7.4']
+        php-version: ['8.1']
     steps:
       - name: Checkout phpBB
         uses: actions/checkout@v5
@@ -107,7 +107,7 @@ jobs:
   mysql-tests:
     if: ${{ !contains(github.event.head_commit.message, 'skip ci') }}
     name: php ${{ matrix.php-version }}, ${{ matrix.db-type }} ${{ matrix.db-version }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     services:
       mysql:
         image: ${{ (matrix.db-type == 'mysql' || matrix.db-type == 'mariadb') && matrix.db-type || 'mariadb' }}:${{ (matrix.db-type == 'mysql' || matrix.db-type == 'mariadb' && matrix.db-version != 'none') && matrix.db-version || 'latest' }}
@@ -129,15 +129,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - php-version: '7.4'
+          - php-version: '8.1'
             db-type: 'mysql'
-            db-version: '8.0'
-          - php-version: '7.4'
-            db-type: 'mariadb'
-            db-version: '10.5'
-          - php-version: '8.0'
-            db-type: 'mariadb'
-            db-version: '10.5'
+            db-version: '5.7'
           - php-version: '8.1'
             db-type: 'mariadb'
             db-version: '10.6'
@@ -222,7 +216,7 @@ jobs:
   postgresql-tests:
     if: ${{ !contains(github.event.head_commit.message, 'skip ci') }}
     name: php ${{ matrix.php-version }}, ${{ matrix.db-type }} ${{ matrix.db-version }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     services:
       postgres:
         image: ${{ (matrix.db-type == 'postgres') && matrix.db-type || 'postgres' }}:${{ (matrix.db-type == 'postgres' && matrix.db-version != 'none') && matrix.db-version || 'alpine' }}
@@ -245,12 +239,12 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - php-version: '7.4'
+          - php-version: '8.1'
             db-type: 'postgres'
-            db-version: '16-alpine'
+            db-version: '17-alpine'
           - php-version: '8.4'
             db-type: 'postgres'
-            db-version: '17-alpine'
+            db-version: '18-alpine'
     steps:
       - name: Checkout phpBB
         uses: actions/checkout@v5

composer.json

@@ -3,8 +3,8 @@
 	"type": "phpbb-extension",
 	"description": "Markdown extension for phpBB",
 	"homepage": "https://github.com/AlfredoRamos/phpbb-ext-markdown",
-	"version": "1.5.0",
-	"time": "2025-09-12",
+	"version": "2.0.0-dev",
+	"time": "2025-09-30",
 	"keywords": [
 		"phpbb",
 		"extension",
@@ -23,7 +23,7 @@
 		}
 	],
 	"require": {
-		"php": "^7.4.0 || ^8.0.0",
+		"php": "^8.1.0",
 		"composer/installers": "^2.2.0"
 	},
 	"require-dev": {
@@ -36,7 +36,7 @@
 	"extra": {
 		"display-name": "Markdown",
 		"soft-require": {
-			"phpbb/phpbb": "~3.3.2"
+			"phpbb/phpbb": "~4.0.0"
 		},
 		"version-check": {
 			"host": "alfredoramos.mx",

ext.php

@@ -14,12 +14,10 @@
 class ext extends base
 {
 	/**
-	 * Check whether or not the extension can be enabled.
-	 *
-	 * @return bool
-	 */
+	* {@inheritdoc}
+	*/
 	public function is_enableable()
 	{
-		return phpbb_version_compare(PHPBB_VERSION, '3.3.2', '>=');
+		return phpbb_version_compare(PHPBB_VERSION, '4.0.0-a1-dev', '>='); // TODO: Use stable version
 	}
 }

styles/prosilver/theme/css/style.css

@@ -69,6 +69,7 @@ h6.markdown {
 table.markdown {
 	margin-top: 1em;
 	margin-bottom: 1em;
+	border-spacing: 0;
 }
 table.markdown,
 table.markdown th,

tests/functional/markdown_test.php

@@ -363,8 +363,8 @@ public function test_inline_spoiler()
 		));
 
 		$expected = <<<EOT
-<p>This is a Reddit-style <span class="spoiler markdown" onclick="removeAttribute('style')" style="background:#444;color:transparent">spoiler</span>.<br>
-This is a Discord-style <span class="spoiler markdown" onclick="removeAttribute('style')" style="background:#444;color:transparent">spoiler</span>.</p>
+<p>This is a Reddit-style <span class="spoiler markdown" onclick="this.removeAttribute('style')" style="background:#444;color:transparent">spoiler</span>.<br>
+This is a Discord-style <span class="spoiler markdown" onclick="this.removeAttribute('style')" style="background:#444;color:transparent">spoiler</span>.</p>
 EOT;
 
 		$result = $crawler->filter(sprintf(